From: Eric Sandeen <sandeen@sandeen.net>
To: Jan Kara <jack@suse.cz>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] Make test 306 use null and zero device nodes on SCRATCH_MNT
Date: Tue, 07 May 2013 19:25:03 -0500 [thread overview]
Message-ID: <51899B5F.2000107@sandeen.net> (raw)
In-Reply-To: <1367964573-29620-2-git-send-email-jack@suse.cz>
On 5/7/13 5:09 PM, Jan Kara wrote:
> In one place of test 306, we mistakenly used /dev/null and /dev/zero
> instead of equivalent devices created on tested filesystem. So we were
> not really testing the functionality we intended.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Ugh. A fine mistake on my part. Thanks for catching that, cripes!
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> tests/generic/306 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/generic/306 b/tests/generic/306
> index e8e0fc0..f45d142 100644
> --- a/tests/generic/306
> +++ b/tests/generic/306
> @@ -73,9 +73,9 @@ _scratch_mount -o ro || _fail "Could not mount scratch readonly"
> echo "== try to create new file"
> touch $SCRATCH_MNT/this_should_fail 2>&1 | _filter_scratch
> echo "== pwrite to null device"
> -$XFS_IO_PROG -F -c "pwrite 0 512" /dev/null | _filter_xfs_io
> +$XFS_IO_PROG -F -c "pwrite 0 512" $DEVNULL | _filter_xfs_io
> echo "== pread from zero device"
> -$XFS_IO_PROG -F -c "pread 0 512" /dev/zero | _filter_xfs_io
> +$XFS_IO_PROG -F -c "pread 0 512" $DEVZERO | _filter_xfs_io
>
> echo "== truncating write to null device"
> echo foo > $DEVNULL 2>&1 | _filter_scratch
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-08 0:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 22:09 [PATCH 1/2] Fix test 298 to work for non-XFS filesystems Jan Kara
2013-05-07 22:09 ` [PATCH 2/2] Make test 306 use null and zero device nodes on SCRATCH_MNT Jan Kara
2013-05-08 0:25 ` Eric Sandeen [this message]
2013-05-14 13:18 ` Rich Johnston
2013-05-07 22:24 ` [PATCH 1/2] Fix test 298 to work for non-XFS filesystems Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51899B5F.2000107@sandeen.net \
--to=sandeen@sandeen.net \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox