From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: quota not supported on realtime filesystems
Date: Wed, 08 May 2013 09:37:25 -0500 [thread overview]
Message-ID: <518A6325.3030809@sandeen.net> (raw)
In-Reply-To: <1367993066-9313-3-git-send-email-david@fromorbit.com>
On 5/8/13 1:04 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Realtime XFS filesystems do not support quotas, so quota tests
> always fail on such filesystems. Add a check to _require_quota to
> detect this situation and notrun the quota tests...
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
(PS why is USE_EXTERNAL a thing? if it's set, shouldn't it be used?)
-Eric
> ---
> common/quota | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/common/quota b/common/quota
> index fd5374f..3550cd4 100644
> --- a/common/quota
> +++ b/common/quota
> @@ -40,6 +40,12 @@ _require_quota()
> if [ ! -f /proc/fs/xfs/xqmstat ]; then
> _notrun "Installed kernel does not support XFS quotas"
> fi
> + if [ "$USE_EXTERNAL" = yes -a ! -z "$TEST_RTDEV" ]; then
> + _notrun "Quotas not supported on realtime test device"
> + fi
> + if [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ]; then
> + _notrun "Quotas not supported on realtime scratch device"
> + fi
> ;;
> *)
> _notrun "disk quotas not supported by this filesystem type: $FSTYP"
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-08 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 6:04 [PATCH 0/2] xfstests: more simple fixes Dave Chinner
2013-05-08 6:04 ` [PATCH 1/2] xfstests: fix incorrect redirect in generic/233 Dave Chinner
2013-05-08 14:34 ` Eric Sandeen
2013-05-14 13:47 ` Rich Johnston
2013-05-08 6:04 ` [PATCH 2/2] xfstests: quota not supported on realtime filesystems Dave Chinner
2013-05-08 14:37 ` Eric Sandeen [this message]
2013-05-08 23:34 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518A6325.3030809@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox