From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 9/8] libxlog: fix log buffer alignment
Date: Thu, 09 May 2013 10:07:17 -0500 [thread overview]
Message-ID: <518BBBA5.3060502@sgi.com> (raw)
In-Reply-To: <20130501001714.GH10481@dastard>
On 04/30/13 19:17, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> The libxlog sync changed the way log buffers used in recovery are
> aligned to sector sizes. The old code used to check for a zero log
> sector size and not do any alignment - this check was removed from
> the kernel code because there is always log sector size configured.
> It turns out that userspace *never* sets the log sector size, so
> userspace has always simply ignored the alignment in log replay
> (oops!).
>
> This problem manifested itself as detecting a freshly mkfs'd
> filesystem as having a totally zeroed log and hence xfs_check was
> emitting output and hence xfstests was refusing to run.
>
> This patch correctly configures the callers that use the log
> recovery code so that the log sector size is set appropriately and
> ensures that log recovery operates as expected.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-09 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130430121300.GB10481@dastard>
2013-05-01 0:17 ` [PATCH 9/8] libxlog: fix log buffer alignment Dave Chinner
2013-05-09 15:07 ` Mark Tinguely [this message]
2013-05-01 6:30 ` [PATCH 10/8] xfsdb: re-instate DA btree node headers Dave Chinner
2013-05-09 15:23 ` Mark Tinguely
2013-05-09 16:21 ` Mark Tinguely
2013-05-01 6:31 ` [PATCH 11/8] xfs_logprint: fix continuation transactions Dave Chinner
2013-05-09 14:59 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518BBBA5.3060502@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox