Re: [PATCH 10/8] xfsdb: re-instate DA btree node headers

Mark Tinguely
2013-05-09T15:23:21Z

On 05/01/13 01:30, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> When removing the dirv1 code, it wasn't immediately obvious that the
> dir v2 code used a small chunk of the dirv1 field definitions. i.e.
> those for the DA btree node headers. Hence bits of xfs_db didn't
> work as expected, and some tests failed in non-obvious ways. e.g
> test 073 failed with this additional line of output:
>
> Use of uninitialized value $logstart in numeric gt (>) at /home/dave/src/xfstests-dev/src/fill2fs line 84
>
> which was the result of the command:
>
> xfs_db -r -c sb -c $TEST_DEV
>
> giving an unexpectedly incorrect output.
>
> Re-instate the needed field definitions and rename them from "DIR"
> to "DA" so it is obvious they are for decoding DA Btree format
> blocks.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---

This no longer cleanly applies.

--Mark.