From: Eric Sandeen <sandeen@sandeen.net>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: Rich Johnston <rjohnston@sgi.com>,
Zheng Liu <wenqing.lz@taobao.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH v5] xfstests: add a new test case for ext4 indirect-based file
Date: Wed, 15 May 2013 10:31:53 -0500 [thread overview]
Message-ID: <5193AA69.7050507@sandeen.net> (raw)
In-Reply-To: <1368463235-14478-1-git-send-email-wenqing.lz@taobao.com>
On 5/13/13 11:40 AM, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> After applied this commit (864688d3), xfstests #255 will not test a
> file system that cannot support fallocate(2), such as a indirect-based
> file in ext4. So we need to add a new generic test case to test it.
>
> The difference between #255 and this test case is only to use pwrite to
> allocate blocks. Other filesystems should survive in this test case.
> In the mean time, a new argument '-u' is added into _test_generic_punch
> not to run unwritten tests.
>
> Meanwhile this commit fixes a minor problem in #255 that testfile should
> use $seq.$$ as testfile.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> Cc: Eric Sandeen <sandeen@sandeen.net>
> Cc: Dave Chinner <david@fromorbit.com>
> Cc: Rich Johnston <rjohnston@sgi.com>
> ---
> changelog:
> * rebase against Eric's patch
> * remove 'prealloc" from group
>
> Hi Eric,
>
> I take a close look at your patch, and 'xfs_io_opt' has been removed in your
> patch. I am not sure whether I need to adjust my patch or not. Please let me
> know if I need to change it. Currently I only remove '-F' argument from test
> case.
xfs_io_opt was an option passed to _test_generic_punch used for "-F", as in:
_test_generic_punch -k falloc fpunch fpunch fiemap _filter_hole_fiemap $testfile -F
-F is no longer needed, so I just dropped the whole thing.
I'm sorry this patch has required so much work. :(
If you simply replace "$xfs_io_opt " with "" in this patch, it applies
again with some fuzz. i.e. in vim I just did:
:%s/$xfs_io_opt //g
to fix up the patch itself.
There is also still one instance of "-F" in the context of the hunk
in tests/generic/255 as well which causes a little fuzz.]
Thank you for your perseverance on this patch. :)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-15 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 16:40 [PATCH v5] xfstests: add a new test case for ext4 indirect-based file Zheng Liu
2013-05-15 13:59 ` Rich Johnston
2013-05-15 15:31 ` Zheng Liu
2013-05-15 15:22 ` Eric Sandeen
2013-05-15 15:31 ` Eric Sandeen [this message]
2013-05-16 3:57 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5193AA69.7050507@sandeen.net \
--to=sandeen@sandeen.net \
--cc=gnehzuil.liu@gmail.com \
--cc=rjohnston@sgi.com \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox