From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id DA0317F4C for ; Wed, 15 May 2013 10:31:55 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id B4669304066 for ; Wed, 15 May 2013 08:31:55 -0700 (PDT) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id ftmtCzGr7e8wEXhn for ; Wed, 15 May 2013 08:31:54 -0700 (PDT) Message-ID: <5193AA69.7050507@sandeen.net> Date: Wed, 15 May 2013 10:31:53 -0500 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH v5] xfstests: add a new test case for ext4 indirect-based file References: <1368463235-14478-1-git-send-email-wenqing.lz@taobao.com> In-Reply-To: <1368463235-14478-1-git-send-email-wenqing.lz@taobao.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Zheng Liu Cc: Rich Johnston , Zheng Liu , xfs@oss.sgi.com On 5/13/13 11:40 AM, Zheng Liu wrote: > From: Zheng Liu > > After applied this commit (864688d3), xfstests #255 will not test a > file system that cannot support fallocate(2), such as a indirect-based > file in ext4. So we need to add a new generic test case to test it. > > The difference between #255 and this test case is only to use pwrite to > allocate blocks. Other filesystems should survive in this test case. > In the mean time, a new argument '-u' is added into _test_generic_punch > not to run unwritten tests. > > Meanwhile this commit fixes a minor problem in #255 that testfile should > use $seq.$$ as testfile. > > Signed-off-by: Zheng Liu > Cc: Eric Sandeen > Cc: Dave Chinner > Cc: Rich Johnston > --- > changelog: > * rebase against Eric's patch > * remove 'prealloc" from group > > Hi Eric, > > I take a close look at your patch, and 'xfs_io_opt' has been removed in your > patch. I am not sure whether I need to adjust my patch or not. Please let me > know if I need to change it. Currently I only remove '-F' argument from test > case. xfs_io_opt was an option passed to _test_generic_punch used for "-F", as in: _test_generic_punch -k falloc fpunch fpunch fiemap _filter_hole_fiemap $testfile -F -F is no longer needed, so I just dropped the whole thing. I'm sorry this patch has required so much work. :( If you simply replace "$xfs_io_opt " with "" in this patch, it applies again with some fuzz. i.e. in vim I just did: :%s/$xfs_io_opt //g to fix up the patch itself. There is also still one instance of "-F" in the context of the hunk in tests/generic/255 as well which causes a little fuzz.] Thank you for your perseverance on this patch. :) -Eric _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs