From: Rich Johnston <rjohnston@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfstests: quota not supported on realtime filesystems
Date: Thu, 16 May 2013 07:32:59 -0500 [thread overview]
Message-ID: <5194D1FB.90004@sgi.com> (raw)
In-Reply-To: <1368062501-15046-3-git-send-email-david@fromorbit.com>
On 05/08/2013 08:21 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Realtime XFS filesystems do not support quotas, so quota tests
> always fail on such filesystems. Add a check to _require_quota to
> detect this situation and notrun the quota tests...
>
> Also, fix _require_xfs_quota and _require_prjquota to have the same
> checks.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> common/quota | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/common/quota b/common/quota
> index fd5374f..b320cf2 100644
> --- a/common/quota
> +++ b/common/quota
> @@ -40,6 +40,12 @@ _require_quota()
> if [ ! -f /proc/fs/xfs/xqmstat ]; then
> _notrun "Installed kernel does not support XFS quotas"
> fi
> + if [ "$USE_EXTERNAL" = yes -a ! -z "$TEST_RTDEV" ]; then
> + _notrun "Quotas not supported on realtime test device"
> + fi
> + if [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ]; then
> + _notrun "Quotas not supported on realtime scratch device"
> + fi
> ;;
> *)
> _notrun "disk quotas not supported by this filesystem type: $FSTYP"
> @@ -62,6 +68,12 @@ _require_xfs_quota()
> {
> src/feature -q $TEST_DEV
> [ $? -ne 0 ] && _notrun "Installed kernel does not support XFS quota"
> + if [ "$USE_EXTERNAL" = yes -a ! -z "$TEST_RTDEV" ]; then
> + _notrun "Quotas not supported on realtime test device"
> + fi
> + if [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ]; then
> + _notrun "Quotas not supported on realtime scratch device"
> + fi
> [ -n $XFS_QUOTA_PROG ] || _notrun "XFS quota user tools not installed"
> }
>
> @@ -73,6 +85,9 @@ _require_prjquota()
> [ -n "$1" ] && _dev="$1" || _dev="$TEST_DEV"
> src/feature -p $_dev
> [ $? -ne 0 ] && _notrun "Installed kernel does not support project quotas"
> + if [ "$USE_EXTERNAL" = yes -a ! -z "$_dev" ]; then
> + _notrun "Project quotas not supported on realtime filesystem"
> + fi
> }
>
> #
>
Another nice cleanup patch, looks good.
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-16 12:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 1:21 [PATCH 0/3, V2] xfstests: more fixes Dave Chinner
2013-05-09 1:21 ` [PATCH 1/3] xfstests: fix incorrect redirect in generic/233 Dave Chinner
2013-05-09 1:21 ` [PATCH 2/3] xfstests: quota not supported on realtime filesystems Dave Chinner
2013-05-16 12:32 ` Rich Johnston [this message]
2013-05-16 12:34 ` Rich Johnston
2013-05-09 1:21 ` [PATCH 3/3] xfstests: generic/235 breaks /etc/mtab symlinks breaks xfs/189 Dave Chinner
2013-05-09 2:46 ` Michael L. Semon
2013-05-09 3:15 ` Dave Chinner
2013-05-16 12:29 ` Rich Johnston
2013-05-16 22:41 ` Dave Chinner
2013-05-17 11:53 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5194D1FB.90004@sgi.com \
--to=rjohnston@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox