From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15])
	by oss.sgi.com (Postfix) with ESMTP id D7DF57F50
	for <xfs@oss.sgi.com>; Fri, 17 May 2013 00:40:27 -0500 (CDT)
Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25])
	by relay3.corp.sgi.com (Postfix) with ESMTP id 65814AC04D
	for <xfs@oss.sgi.com>; Thu, 16 May 2013 22:40:27 -0700 (PDT)
Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by
	cuda.sgi.com with ESMTP id XqMGdmCC134F1p6X (version=TLSv1
	cipher=AES256-SHA bits=256 verify=NO) for <xfs@oss.sgi.com>;
	Thu, 16 May 2013 22:40:26 -0700 (PDT)
Message-ID: <5195C2C3.3000603@oracle.com>
Date: Fri, 17 May 2013 13:40:19 +0800
From: Jeff Liu <jeff.liu@oracle.com>
MIME-Version: 1.0
Subject: Re: [PATCH v8 2/5] xfs: Add pquota fields where gquota is used.
References: <1368220889-25188-1-git-send-email-sekharan@us.ibm.com>
	<1368220889-25188-3-git-send-email-sekharan@us.ibm.com>
	<51906528.3030307@oracle.com> <20130517030125.GT29466@dastard>
In-Reply-To: <20130517030125.GT29466@dastard>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: xfs-bounces@oss.sgi.com
Sender: xfs-bounces@oss.sgi.com
To: Dave Chinner <david@fromorbit.com>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>, xfs@oss.sgi.com

On 05/17/2013 11:01 AM, Dave Chinner wrote:
> On Mon, May 13, 2013 at 11:59:36AM +0800, Jeff Liu wrote:
>> Hi,
>>
>>> +struct xfs_inode *
>>> +xfs_dq_to_quota_inode(struct xfs_dquot *dqp)
>>> +{
>>> +	if (XFS_QM_ISUDQ(dqp))
>>> +		return dqp->q_mount->m_quotainfo->qi_uquotaip;
>>> +	if (XFS_QM_ISGDQ(dqp))
>>> +		return dqp->q_mount->m_quotainfo->qi_gquotaip;
>>> +	ASSERT(XFS_QM_ISPDQ(dqp));
>>> +	return dqp->q_mount->m_quotainfo->qi_pquotaip;
>>> +}
>> Is it better to replace above conditional judgment with 'switch...case'?
>> i.e.
>> static inline struct xfs_inode *
>> xfs_dq_to_qip(struct xfs_dquot *dqp)
>> {
>> 	switch (dqp->dq_flags) {
>> 	case XFS_DQ_USER:
>> 		return dqp->q_mount->m_quotainfo->qi_uquotaip;
>> 	case XFS_DQ_GROUP:
>> 		return dqp->q_mount->m_quotainfo->qi_gqoutaip;
>> 	case XFS_DQ_PROJ:
>> 		return dqp->q_mount->m_quotainfo->qi_pquotaip;
>> 	}
> 
> Doesn't work because dq_flags can have other fields set in it (e.g
> XFS_DQ_DIRTY). It would need to be:
> 
> 	switch (dqp->dq_flags & XFS_DQ_ALLTYPES) {
> 	....
> 	}
Ah, yep. thanks for the teaching. :)

Thanks,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs