[PATCH v2] xfstests: check falloc in 285

[PATCH v2] xfstests: check falloc in 285

[Zheng Liu]

From: Zheng Liu <wenqing.lz@taobao.com>

As linux 3.8, ext4 has supported the seek data/hole operation for
extent-based file and indirect-based file.  But for indirect-based file
it can not support the fallocate(2).  This causes test 285 to fail since
it assumes that all file systems which supports seek data/hole also
support fallocate.  So here we need to check it.

Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Cc: Rich Johnston <rjohnston@sgi.com>
---
 tests/generic/285 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/generic/285 b/tests/generic/285
index 22b4a08..d1a1baa 100644
--- a/tests/generic/285
+++ b/tests/generic/285
@@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fs generic
 _supported_os Linux
 
+_require_xfs_io_falloc
+
 BASE_TEST_FILE=$TEST_DIR/seek_sanity_testfile
 
 [ -x $here/src/seek_sanity_test ] || _notrun "seek_sanitfy_tester not built"
-- 
1.7.12.rc2.18.g61b472e

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH v2] xfstests: check falloc in 285

[Rich Johnston]

On 05/12/2013 04:42 AM, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> As linux 3.8, ext4 has supported the seek data/hole operation for
> extent-based file and indirect-based file.  But for indirect-based file
> it can not support the fallocate(2).  This causes test 285 to fail since
> it assumes that all file systems which supports seek data/hole also
> support fallocate.  So here we need to check it.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> Cc: Rich Johnston <rjohnston@sgi.com>
> ---
>   tests/generic/285 | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/generic/285 b/tests/generic/285
> index 22b4a08..d1a1baa 100644
> --- a/tests/generic/285
> +++ b/tests/generic/285
> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>   _supported_fs generic
>   _supported_os Linux
>
> +_require_xfs_io_falloc
> +
>   BASE_TEST_FILE=$TEST_DIR/seek_sanity_testfile
>
>   [ -x $here/src/seek_sanity_test ] || _notrun "seek_sanitfy_tester not built"
>

Looks good.

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH v2] xfstests: check falloc in 285

[Rich Johnston]

On 05/12/2013 04:42 AM, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> As linux 3.8, ext4 has supported the seek data/hole operation for
> extent-based file and indirect-based file.  But for indirect-based file
> it can not support the fallocate(2).  This causes test 285 to fail since
> it assumes that all file systems which supports seek data/hole also
> support fallocate.  So here we need to check it.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>

Zheng, this has been committed:

commit fd0afdb443cae47a3963dd8a23fd9785f1f4aebc
Author: Zheng Liu <wenqing.lz@taobao.com>
Date:   Thu May 16 08:49:03 2013 -0500

     xfstests: check falloc in 285

Thanks
--Rich

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs