public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael L. Semon" <mlsemon35@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: [PATCH] xfstests: Change mount method for shared/243
Date: Wed, 22 May 2013 22:27:21 -0400	[thread overview]
Message-ID: <519D7E89.8060201@gmail.com> (raw)
In-Reply-To: <20130522012620.GA29466@dastard>

Hi!  This patch updates the mount method in xfstests shared/243 
without seeming to change the behavior of the test.  Should this 
patch get a NACK for not being useful, no worries!  There will be 
other opportunities.

The patch was tested with ext4, with and without external journals. 
It was also tested on XFS with an external logdev.  The MOUNT_OPTIONS 
for the ext4 tests included '-o barrier=1' and '-o barrier=0'.  The 
test results varied on ext4 with an external journal, but the 
results shown by /proc/mounts was OK.  [barrier=1 causes a failed 
test, barrier=0 succeeds, both in the original and patched test.]

>From 8762f621a5fb9556fa96ec289bceffc4fcc844f3 Mon Sep 17 00:00:00 2001
From: "Michael L. Semon" <mlsemon35@gmail.com>
Date: Wed, 22 May 2013 20:57:56 -0400
Subject: [PATCH] xfstests: Change mount method for shared/243

Change the mount invocations in shared/243 to use the built-in
_test_mount function of xfstests.  This was done as part of a
clean-up recommendation.  Currently, only ext4 file systems are
affected by this change.

Signed-off-by: Michael L. Semon <mlsemon35@gmail.com>
---
 tests/shared/243 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/shared/243 b/tests/shared/243
index e0f2db2..b3eb025 100755
--- a/tests/shared/243
+++ b/tests/shared/243
@@ -108,7 +108,7 @@ _check_ext4_eof_flag()
     fi
 
     # Mount the ${TEST_DEV}
-    mount ${TEST_DEV} -t ${FSTYP} ${TEST_DIR}
+    _test_mount
   fi
 }
 
-- 
1.8.2


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2013-05-23  2:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22  0:43 generic/258 questions (mount issue) Michael L. Semon
2013-05-22  1:26 ` Dave Chinner
2013-05-22  3:03   ` Michael L. Semon
2013-05-22 14:10     ` Eric Sandeen
2013-05-22 16:15       ` Michael L. Semon
2013-05-22 16:19         ` Eric Sandeen
2013-05-22 16:48           ` Michael L. Semon
2013-05-22 17:08             ` Eric Sandeen
2013-05-22 19:01     ` Rich Johnston
2013-05-22 22:58   ` Michael L. Semon
2013-05-23  2:27   ` Michael L. Semon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519D7E89.8060201@gmail.com \
    --to=mlsemon35@gmail.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox