* [PATCH] xfstests: cleanup the codes related to h_chksum
@ 2013-05-25 23:15 zwu.kernel
2013-05-26 21:37 ` Michael L. Semon
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: zwu.kernel @ 2013-05-25 23:15 UTC (permalink / raw)
To: xfs; +Cc: Zhi Yong Wu
From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Since h_chksum field has gone away, we should cleanup the related codes
[CC] loggen
loggen.c: In function 'loggen_unmount':
loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
loggen.c: In function 'loggen_empty':
loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
src/loggen.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/loggen.c b/src/loggen.c
index 4b55667..522c917 100644
--- a/src/loggen.c
+++ b/src/loggen.c
@@ -134,7 +134,6 @@ loggen_unmount(int count)
head->h_cycle = cpu_to_be32(param_cycle);
head->h_version = cpu_to_be32(1);
head->h_len = cpu_to_be32(20);
- head->h_chksum = cpu_to_be32(0);
head->h_prev_block = cpu_to_be32(-1);
head->h_num_logops = cpu_to_be32(1);
head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
@@ -202,7 +201,6 @@ loggen_empty(int count)
sizeof(xfs_trans_header_t)+
sizeof(xfs_buf_log_format_t)+
sizeof(int));
- head->h_chksum = cpu_to_be32(0);
head->h_prev_block = cpu_to_be32(-1);
head->h_num_logops = cpu_to_be32(5);
head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
--
1.7.6.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] xfstests: cleanup the codes related to h_chksum
2013-05-25 23:15 [PATCH] xfstests: cleanup the codes related to h_chksum zwu.kernel
@ 2013-05-26 21:37 ` Michael L. Semon
2013-05-27 1:21 ` Zhi Yong Wu
2013-05-26 23:13 ` Dave Chinner
2013-05-28 15:26 ` Rich Johnston
2 siblings, 1 reply; 5+ messages in thread
From: Michael L. Semon @ 2013-05-26 21:37 UTC (permalink / raw)
To: zwu.kernel; +Cc: Zhi Yong Wu, xfs
On 05/25/2013 07:15 PM, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Since h_chksum field has gone away, we should cleanup the related codes
>
> [CC] loggen
> loggen.c: In function 'loggen_unmount':
> loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
> loggen.c: In function 'loggen_empty':
> loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
> src/loggen.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/src/loggen.c b/src/loggen.c
> index 4b55667..522c917 100644
> --- a/src/loggen.c
> +++ b/src/loggen.c
> @@ -134,7 +134,6 @@ loggen_unmount(int count)
> head->h_cycle = cpu_to_be32(param_cycle);
> head->h_version = cpu_to_be32(1);
> head->h_len = cpu_to_be32(20);
> - head->h_chksum = cpu_to_be32(0);
> head->h_prev_block = cpu_to_be32(-1);
> head->h_num_logops = cpu_to_be32(1);
> head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
> @@ -202,7 +201,6 @@ loggen_empty(int count)
> sizeof(xfs_trans_header_t)+
> sizeof(xfs_buf_log_format_t)+
> sizeof(int));
> - head->h_chksum = cpu_to_be32(0);
> head->h_prev_block = cpu_to_be32(-1);
> head->h_num_logops = cpu_to_be32(5);
> head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
>
I've been taking a wild guess and changing "h_chksum" to "h_crc", just
as a pure sysadmin hack to keep going. Is there more than one correct
answer on this issue?
Michael
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfstests: cleanup the codes related to h_chksum
2013-05-26 21:37 ` Michael L. Semon
@ 2013-05-27 1:21 ` Zhi Yong Wu
0 siblings, 0 replies; 5+ messages in thread
From: Zhi Yong Wu @ 2013-05-27 1:21 UTC (permalink / raw)
To: Michael L. Semon; +Cc: Zhi Yong Wu, xfstests
[-- Attachment #1.1: Type: text/plain, Size: 1899 bytes --]
HI,
I don't think that this is one hacking, but one formal patch to fix this
issue.
On Mon, May 27, 2013 at 5:37 AM, Michael L. Semon <mlsemon35@gmail.com>wrote:
> On 05/25/2013 07:15 PM, zwu.kernel@gmail.com wrote:
> > From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> >
> > Since h_chksum field has gone away, we should cleanup the related codes
> >
> > [CC] loggen
> > loggen.c: In function 'loggen_unmount':
> > loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
> > loggen.c: In function 'loggen_empty':
> > loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
> >
> > Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> > ---
> > src/loggen.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/loggen.c b/src/loggen.c
> > index 4b55667..522c917 100644
> > --- a/src/loggen.c
> > +++ b/src/loggen.c
> > @@ -134,7 +134,6 @@ loggen_unmount(int count)
> > head->h_cycle = cpu_to_be32(param_cycle);
> > head->h_version = cpu_to_be32(1);
> > head->h_len = cpu_to_be32(20);
> > - head->h_chksum = cpu_to_be32(0);
> > head->h_prev_block = cpu_to_be32(-1);
> > head->h_num_logops = cpu_to_be32(1);
> > head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
> > @@ -202,7 +201,6 @@ loggen_empty(int count)
> >
> sizeof(xfs_trans_header_t)+
> >
> sizeof(xfs_buf_log_format_t)+
> > sizeof(int));
> > - head->h_chksum = cpu_to_be32(0);
> > head->h_prev_block = cpu_to_be32(-1);
> > head->h_num_logops = cpu_to_be32(5);
> > head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
> >
>
> I've been taking a wild guess and changing "h_chksum" to "h_crc", just
> as a pure sysadmin hack to keep going. Is there more than one correct
> answer on this issue?
>
> Michael
>
>
--
Regards,
Zhi Yong Wu
[-- Attachment #1.2: Type: text/html, Size: 2977 bytes --]
[-- Attachment #2: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfstests: cleanup the codes related to h_chksum
2013-05-25 23:15 [PATCH] xfstests: cleanup the codes related to h_chksum zwu.kernel
2013-05-26 21:37 ` Michael L. Semon
@ 2013-05-26 23:13 ` Dave Chinner
2013-05-28 15:26 ` Rich Johnston
2 siblings, 0 replies; 5+ messages in thread
From: Dave Chinner @ 2013-05-26 23:13 UTC (permalink / raw)
To: zwu.kernel; +Cc: Zhi Yong Wu, xfs
On Sun, May 26, 2013 at 07:15:32AM +0800, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Since h_chksum field has gone away, we should cleanup the related codes
>
> [CC] loggen
> loggen.c: In function 'loggen_unmount':
> loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
> loggen.c: In function 'loggen_empty':
> loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfstests: cleanup the codes related to h_chksum
2013-05-25 23:15 [PATCH] xfstests: cleanup the codes related to h_chksum zwu.kernel
2013-05-26 21:37 ` Michael L. Semon
2013-05-26 23:13 ` Dave Chinner
@ 2013-05-28 15:26 ` Rich Johnston
2 siblings, 0 replies; 5+ messages in thread
From: Rich Johnston @ 2013-05-28 15:26 UTC (permalink / raw)
To: zwu.kernel; +Cc: Zhi Yong Wu, xfs
On 05/25/2013 06:15 PM, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Since h_chksum field has gone away, we should cleanup the related codes
>
> [CC] loggen
> loggen.c: In function 'loggen_unmount':
> loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
> loggen.c: In function 'loggen_empty':
> loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Thanks for the patch, it has been committed:
commit f761cd9a6aa9b44be7f3056f01c419edf1356789
Author: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Date: Tue May 28 08:31:52 2013 -0500
xfstests: cleanup the codes related to h_chksum
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-28 15:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-25 23:15 [PATCH] xfstests: cleanup the codes related to h_chksum zwu.kernel
2013-05-26 21:37 ` Michael L. Semon
2013-05-27 1:21 ` Zhi Yong Wu
2013-05-26 23:13 ` Dave Chinner
2013-05-28 15:26 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox