From: Eric Sandeen <sandeen@sandeen.net>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add missing colon in _filter_ln
Date: Wed, 29 May 2013 11:21:16 -0500 [thread overview]
Message-ID: <51A62AFC.9050704@sandeen.net> (raw)
In-Reply-To: <1369842106-9869-1-git-send-email-eguan@redhat.com>
On 5/29/13 10:41 AM, Eryu Guan wrote:
> On distros with older coreutils(eg. RHEL5) generic/294 fails like
>
> -ln: creating symbolic link `SCRATCH_MNT/294.test/testlink': File exists
> +ln: creating symbolic link `SCRATCH_MNT/294.test/testlink'File exists
>
> _filter_ln ate the ": ". xfs/103 has similar issue. Add ": " back.
Ok, so older coreutils does i.e.:
ln: creating symbolic link `b' to `a': File exists
and newer:
ln: creating symbolic link `b': File exists
We want to convert the older output to the newer, by removing the " to `a'" part.
Seems like my sed script is the long way around that ;)
Still, looks like your fix does the right thing, thanks.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
-Eric
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> common/filter | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/filter b/common/filter
> index bdd6427..dbb1674 100644
> --- a/common/filter
> +++ b/common/filter
> @@ -243,7 +243,7 @@ _filter_spaces()
> # Account for different "ln" failure messages
> _filter_ln()
> {
> - sed -e "s,\(creating symbolic link .*\) to .*: ,\1," \
> + sed -e "s,\(creating symbolic link .*\) to .*: ,\1: ," \
> -e "s,failed to create,creating,"
> }
>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-29 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 15:41 [PATCH] xfstests: add missing colon in _filter_ln Eryu Guan
2013-05-29 16:21 ` Eric Sandeen [this message]
2013-05-29 19:45 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A62AFC.9050704@sandeen.net \
--to=sandeen@sandeen.net \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox