From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id E9FC429DF8 for ; Wed, 29 May 2013 14:21:54 -0500 (CDT) Message-ID: <51A65550.50508@sgi.com> Date: Wed, 29 May 2013 14:21:52 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 5/9] xfs: fix split buffer vector log recovery support References: <1369636707-15150-1-git-send-email-david@fromorbit.com> <1369636707-15150-6-git-send-email-david@fromorbit.com> In-Reply-To: <1369636707-15150-6-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 05/27/13 01:38, Dave Chinner wrote: > From: Dave Chinner > > A long time ago in a galaxy far away.... > > .. the was a commit made to fix some ilinux specific "fragmented > buffer" log recovery problem: > > http://oss.sgi.com/cgi-bin/gitweb.cgi?p=archive/xfs-import.git;a=commitdiff;h=b29c0bece51da72fb3ff3b61391a391ea54e1603 > > That problem occurred when a contiguous dirty region of a buffer was > split across across two pages of an unmapped buffer. It's been a > long time since that has been done in XFS, and the changes to log > the entire inode buffers for CRC enabled filesystems has > re-introduced that corner case. > > And, of course, it turns out that the above commit didn't actually > fix anything - it just ensured that log recovery is guaranteed to > fail when this situation occurs. And now for the gory details. > ... Thanks for the great walk through of the problem. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs