From: Eric Sandeen <sandeen@sandeen.net>
To: alexander.tsvetkov@oracle.com
Cc: xfs@oss.sgi.com
Subject: Re: XFStest suite problem
Date: Thu, 30 May 2013 08:42:29 -0500 [thread overview]
Message-ID: <51A75745.7090805@sandeen.net> (raw)
In-Reply-To: <51A708B2.2080701@oracle.com>
On 5/30/13 3:07 AM, alexander.tsvetkov@oracle.com wrote:
> I think the following code of "check" script incorrectly builds this exclude list:
>
> "-X) xfile=$2; shift ;
> for d in $SRC_GROUPS $FSTYP; do
> [ -f $SRC_DIR/$d/$xfile ] || continue
> for f in `cat $SRC_DIR/$d/$xfile`; do
> echo $d/$f >> $tmp.xlist
Well, it is perhaps unexpected, but:
-X file exclude individual tests
I think it's designed to actually exclude tests contained in that file, not test numbers. It's not very obvious. :(
But from the commit log:
commit 0b1e8abd4a6dbce54bcc5d0467e58966e41e7eb8
Author: Dave Chinner <dchinner@redhat.com>
Date: Fri Mar 15 12:28:05 2013 +0000
xfstests: Reintroduce configurable test expunging.
It is definitely handy to be able to disabdle certain tests (e.g. tests that are
known to hang or crash the test machine on certain kernels), so re-introducing
the capability of avoiding certain tests just by placing them in a file is
useful.
Introduce a command line option to specify the expunged file name. The file will
exist in each tests/* sub-directory so that only the testname is required, and
can be managed independently. The use of a command line parameter allows
multiple expunge files to exist simultaneously in the one xfstests tree which
simplifies management of a source repository used for multiple versions of a
distro.
Typical usage:
$ cat tests/generic/3.0-stable-avoid
280
$ sudo ./check -X 3.0-stable-avoid generic/280
FSTYP -- xfs (debug)
PLATFORM -- Linux/x86_64 test-1 3.0.39-dgc+
MKFS_OPTIONS -- -f -bsize=4096 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/scratch
generic/280 [expunged]
Passed all 0 tests
$
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-30 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 8:07 XFStest suite problem alexander.tsvetkov
2013-05-30 13:42 ` Eric Sandeen [this message]
2013-05-30 22:43 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A75745.7090805@sandeen.net \
--to=sandeen@sandeen.net \
--cc=alexander.tsvetkov@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox