From: Rich Johnston <rjohnston@sgi.com>
To: xfstests <xfs@oss.sgi.com>
Subject: [PATCH] xfstests: Fix test wildcard expansion.
Date: Thu, 30 May 2013 17:02:19 -0500 [thread overview]
Message-ID: <51A7CC6B.3030607@sgi.com> (raw)
Before commit 38d58591 "xfstests: fix typo in check",
check xfs/[0-9]?? would execute all tests/xfs/[0-9]?? because:
'if grep "^$testname" $group_file >/dev/null'
returns the contents of $group_file because $testname="".
Therefore xfs/[0-9]?? was echoed to $tmp.list
Fix the parsing in check to expand the regular expressions for test names.
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
---
diff --git a/check b/check
index 8d32486..eb5d9be 100755
--- a/check
+++ b/check
@@ -242,13 +242,15 @@ if $have_test_arg; then
test_name=`basename $1`
group_file=$SRC_DIR/$test_dir/group
- if grep "^$test_name" $group_file >/dev/null ; then
- # in group file ... OK
- echo $SRC_DIR/$1 >>$tmp.list
- else
- # oops
- echo "$1 - unknown test, ignored"
- fi
+ for f in `cd $SRC_DIR/$test_dir; ls $test_name`; do
+ if grep "^$f" $group_file >/dev/null ; then
+ # in group file ... OK
+ echo $SRC_DIR/$test_dir/$f >>$tmp.list
+ else
+ # oops
+ echo "$test_dir/$f - unknown test, ignored"
+ fi
+ done
;;
esac
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2013-05-30 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 22:02 Rich Johnston [this message]
2013-05-30 22:12 ` [PATCH] xfstests: Fix test wildcard expansion Dave Chinner
2013-05-30 22:32 ` [PATCH V2] " Rich Johnston
2013-05-30 22:38 ` Dave Chinner
2013-05-31 12:10 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A7CC6B.3030607@sgi.com \
--to=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox