From: Rich Johnston <rjohnston@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfstests <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests: Fix test wildcard expansion.
Date: Fri, 31 May 2013 07:10:10 -0500 [thread overview]
Message-ID: <51A89322.5090302@sgi.com> (raw)
In-Reply-To: <20130530223823.GS29466@dastard>
On 05/30/2013 05:38 PM, Dave Chinner wrote:
> On Thu, May 30, 2013 at 05:32:48PM -0500, Rich Johnston wrote:
>>
>> Before commit 38d58591 "xfstests: fix typo in check",
>> check xfs/[0-9]?? would execute all tests/xfs/[0-9]?? because:
>>
>> Change to use egrep to fix the parsing.
>>
>> Signed-off-by: Rich Johnston <rjohnston@sgi.com>
>> ---
>> V1-V2
>> Use egrep instead of my bulky method
>
> looks like you lost a bit of the commit message. Otherwise it works
> fine here ;)
Oops dang cut/paste, I put it back.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
Thanks for the review Dave.
commit 9267afb16b8e861888e54f829015667753034980
Author: Rich Johnston <rjohnston@sgi.com>
Date: Fri May 31 07:02:48 2013 -0500
xfstests: Fix test wildcard expansion.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-05-31 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 22:02 [PATCH] xfstests: Fix test wildcard expansion Rich Johnston
2013-05-30 22:12 ` Dave Chinner
2013-05-30 22:32 ` [PATCH V2] " Rich Johnston
2013-05-30 22:38 ` Dave Chinner
2013-05-31 12:10 ` Rich Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A89322.5090302@sgi.com \
--to=rjohnston@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox