From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: bpm@sgi.com, xfs@oss.sgi.com
Subject: Re: [PATCH 4/6] xfs: fix remote attribute invalidation for a leaf
Date: Mon, 03 Jun 2013 14:09:48 -0500 [thread overview]
Message-ID: <51ACE9FC.9010008@sgi.com> (raw)
In-Reply-To: <1370237332-24757-5-git-send-email-david@fromorbit.com>
On 06/03/13 00:28, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> When invalidating an attribute leaf block block, there might be
> remote attributes that it points to. With the recent rework of the
> remote attribute format, we have to make sure we calculate the
> length of the attribute correctly. We aren't doing that in
> xfs_attr3_leaf_inactive(), so fix it.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
I scratched my head reading:
in xfs_attr_leaf.h:
/*
* Used to keep a list of "remote value" extents when unlinking an inode.
*/
typedef struct xfs_attr_inactive_list {
xfs_dablk_t valueblk; /* block number of value bytes */
int valuelen; /* number of bytes in value */
^^^^^
|||||
} xfs_attr_inactive_list_t;
Where "valuelen" is clearly being used as blocks. A more obvious name is
the former "valueblk". Blame commit d7929ff6 for the confusion. Should
change
the comment and/or variable one of these days ...
Reviewed-by: Mark Tinguely <tinuguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-03 19:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 5:28 [PATCH 0/6] xfs: fixes for 3.10-rc4 Dave Chinner
2013-06-03 5:28 ` [PATCH 1/6] xfs: rework dquot CRCs Dave Chinner
2013-06-03 18:18 ` Brian Foster
2013-06-04 21:46 ` Ben Myers
2013-06-04 22:07 ` Ben Myers
2013-06-03 5:28 ` [PATCH 2/6] xfs: fix log recovery transaction item reordering Dave Chinner
2013-06-03 5:28 ` [PATCH 3/6] xfs: inode unlinked list needs to recalculate the inode CRC Dave Chinner
2013-06-03 18:18 ` Brian Foster
2013-06-04 3:06 ` Dave Chinner
2013-06-03 5:28 ` [PATCH 4/6] xfs: fix remote attribute invalidation for a leaf Dave Chinner
2013-06-03 18:59 ` Brian Foster
2013-06-03 19:09 ` Mark Tinguely [this message]
2013-06-04 3:13 ` Dave Chinner
2013-06-04 22:28 ` Ben Myers
2013-06-03 5:28 ` [PATCH 5/6] xfs: disable noattr2/attr2 mount options for CRC enabled filesystems Dave Chinner
2013-06-03 19:02 ` Brian Foster
2013-06-03 21:38 ` Mark Tinguely
2013-06-05 1:49 ` Dave Chinner
2013-06-03 5:28 ` [PATCH 6/6] xfs: increase number of ACL entries for V5 superblocks Dave Chinner
2013-06-03 22:08 ` Mark Tinguely
2013-06-04 3:26 ` Dave Chinner
2013-06-05 1:58 ` Dave Chinner
2013-06-04 15:34 ` Ben Myers
2013-06-04 22:29 ` Dave Chinner
2013-06-04 22:32 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ACE9FC.9010008@sgi.com \
--to=tinguely@sgi.com \
--cc=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox