From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 29D5E7CBF for ; Mon, 3 Jun 2013 14:09:51 -0500 (CDT) Message-ID: <51ACE9FC.9010008@sgi.com> Date: Mon, 03 Jun 2013 14:09:48 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 4/6] xfs: fix remote attribute invalidation for a leaf References: <1370237332-24757-1-git-send-email-david@fromorbit.com> <1370237332-24757-5-git-send-email-david@fromorbit.com> In-Reply-To: <1370237332-24757-5-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: bpm@sgi.com, xfs@oss.sgi.com On 06/03/13 00:28, Dave Chinner wrote: > From: Dave Chinner > > When invalidating an attribute leaf block block, there might be > remote attributes that it points to. With the recent rework of the > remote attribute format, we have to make sure we calculate the > length of the attribute correctly. We aren't doing that in > xfs_attr3_leaf_inactive(), so fix it. > > Signed-off-by: Dave Chinner I scratched my head reading: in xfs_attr_leaf.h: /* * Used to keep a list of "remote value" extents when unlinking an inode. */ typedef struct xfs_attr_inactive_list { xfs_dablk_t valueblk; /* block number of value bytes */ int valuelen; /* number of bytes in value */ ^^^^^ ||||| } xfs_attr_inactive_list_t; Where "valuelen" is clearly being used as blocks. A more obvious name is the former "valueblk". Blame commit d7929ff6 for the confusion. Should change the comment and/or variable one of these days ... Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs