From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] xfs: inode unlinked list needs to recalculate the inode CRC
Date: Wed, 05 Jun 2013 09:43:32 -0500 [thread overview]
Message-ID: <51AF4E94.4020200@sgi.com> (raw)
In-Reply-To: <1370398150-12084-3-git-send-email-david@fromorbit.com>
On 06/04/13 21:09, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> The inode unlinked list manipulations operate directly on the inode
> buffer, and so bypass the inode CRC calculation mechanisms. Hence an
> inode on the unlinked list has an invalid CRC. Fix this by
> recalculating the CRC whenever we modify an unlinked list pointer in
> an inode, ncluding during log recovery. This is trivial to do and
> results in unlinked list operations always leaving a consistent
> inode in the buffer.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-05 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 2:09 [PATCH 0/4] xfs: outstanding fixes for 3.10 Dave Chinner
2013-06-05 2:09 ` [PATCH 1/4] xfs: fix log recovery transaction item reordering Dave Chinner
2013-06-05 13:13 ` Mark Tinguely
2013-06-05 2:09 ` [PATCH 2/4] xfs: inode unlinked list needs to recalculate the inode CRC Dave Chinner
2013-06-05 14:43 ` Mark Tinguely [this message]
2013-06-05 2:09 ` [PATCH 3/4] xfs: disable noattr2/attr2 mount options for CRC enabled filesystems Dave Chinner
2013-06-05 2:09 ` [PATCH 4/4] xfs: increase number of ACL entries for V5 superblocks Dave Chinner
2013-06-05 13:26 ` Mark Tinguely
2013-06-05 13:38 ` Mark Tinguely
2013-06-05 16:44 ` [PATCH 0/4] xfs: outstanding fixes for 3.10 Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF4E94.4020200@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox