Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file

Christoph Hellwig
2013-06-12T14:05:24Z

On Wed, Jun 12, 2013 at 08:22:38PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The core xfs inode operations such as locking, allocation, reading
> and writing are not shared with userspace. However, much of the
> remaining internal inode code such as the incore extent tracking and
> formatting is. Split the XFS inode operations out into a new
> xfs_inode_iops.c file to minimise the differences between the files
> shred with userspace.

Having struct xfs_inode in an xfs_inode_ops.h file while xfs_inode.h
is still around strikes me as extremely odd. It seems like icdinode
should be in xfs_inode_item.h as is part of the log format primarily.