Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file

Dave Chinner
2013-06-18T22:02:38Z

On Tue, Jun 18, 2013 at 04:37:15PM -0500, Ben Myers wrote:
> On Wed, Jun 19, 2013 at 06:40:11AM +1000, Dave Chinner wrote:
> > On Mon, Jun 17, 2013 at 01:14:11PM -0500, Ben Myers wrote:
> > > > Using a directly also would make
> > > > sense, but for some reason Kbuild always had problems with modules built
> > > > from multiple directories and I'm more than glad that we finally managed
> > > > to get rid of the subdirectories.
> > >
> > > but I really like the libxfs subdirectory idea. Any idea if the Kbuild issues
> > > are sorted out?
> >
> > No idea - I don't know the issue is.
> >
> > However, if the issue has been fixed (or could be easily solved)
> > then it seems like there is a rough agreement on moving towards a
> > common shared libxfs base?
>
> Yeah, it sounds like it... regardless of whether it goes into a separate
> directory. I would also be good to get that old xfstest going again. Looks
> like it was 040.

Which was dependent on the old integrated Irix ptools source tree
structure for xfs-cmds (i.e. prior to separate GPL source trees for
xfsprogs, etc). It hasn't been updated since 2003 and so doesn't
even have "supported_os" tag in it. I'm pretty sure that getting it
to "work" is more hassle than it's worth because the diffs will
never been clean like they were on irix where libxfs was an ism link
to the kernel code from within the xfs-cmds ism...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com