Re: [PATCH 27/27] xfs: fix issues that cause userspace warnings

Dave Chinner
2013-06-18T21:42:29Z

On Mon, Jun 17, 2013 at 03:32:23PM -0400, Brian Foster wrote:
> On 06/12/2013 06:22 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Some of the code shared with userspace causes compilation warnings
> > from things turned off in the kernel code, such as differences in
> > variable signedness. Fix those issues.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > ---
> > fs/xfs/xfs_attr_remote.c | 8 ++++----
> > fs/xfs/xfs_bmap.c | 3 ---
> > fs/xfs/xfs_da_btree.c | 6 +++---
> > fs/xfs/xfs_dir2_node.c | 2 ++
> > fs/xfs/xfs_ialloc.c | 2 +-
> > fs/xfs/xfs_rtalloc.c | 4 ++--
> > 6 files changed, 12 insertions(+), 13 deletions(-)
> >
> ...
> >
> > diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c
> > index 319d9e4..9831eff 100644
> > --- a/fs/xfs/xfs_ialloc.c
> > +++ b/fs/xfs/xfs_ialloc.c
> > @@ -1342,7 +1342,7 @@ xfs_imap(
> > xfs_agblock_t cluster_agbno; /* first block in inode cluster */
> > int error; /* error code */
> > int offset; /* index of inode in its buffer */
> > - int offset_agbno; /* blks from chunk start to inode */
> > + xfs_agino_t offset_agbno; /* blks from chunk start to inode */
>
> xfs_agblock_t ?

Good catch. Brainfart - inode allocation code, must be an agino :P

Cheers,

Dave
--
Dave Chinner
david@fromorbit.com