dmsetup arguments

dmsetup arguments

[alexander.tsvetkov]

[-- Attachment #1.1: Type: text/plain, Size: 1749 bytes --]

Hi,

XFStests suite generic/311 test fails on command: "sbin/dmsetup load 
flakey-test --table "0 150000001 flakey /dev/sdc2 0 0 180 1 drop_writes" 
with error: "device-mapper: reload ioctl on flakey-test failed: Invalid 
argument", so as I understand the command format provided to ioctl is 
incorrect here. Kernel logs has message:

"Jun 13 16:47:15 tests kernel: device-mapper: table: 252:3: flakey: 
dm-flakey: Invalid argument count
Jun 13 16:47:15 tests kernel: device-mapper: ioctl: error adding target 
to table"

Looking into the source code of package LVM2.02.98 which devmapper 
library belongs to I find argument "drop_writes" used in the command 
only in documentation doc/kernel/flakey.txt:

"Optional feature parameters:
   If no feature parameters are present, during the periods of
   unreliability, all I/O returns errors.

   drop_writes:
         All write I/O is silently ignored.
         Read I/O is handled correctly."

This argument feature was added in the patch from "27 Jun 2011":

"[dm-devel] [PATCH 0/9] dm flakey: add features
------------------------------------------------------------------------

    * /From/: Mike Snitzer <snitzer redhat com>
    * /To/: <dm-devel redhat com>
    * /Cc/: Mike Snitzer <snitzer redhat com>
    * /Subject/: [dm-devel] [PATCH 0/9] dm flakey: add features
    * /Date/: Mon, 27 Jun 2011 15:53:34 -0400

------------------------------------------------------------------------

Add "drop_writes", "corrupt_bio_byte" and "debug" features to the
flakey target."

https://www.redhat.com/archives/dm-devel/2011-June/msg00081.html

but was patch modifications included in library of LVM2.02.98 package? 
Or may be it was already removed from it after?

Thanks,
Alexander Tsvetkov








[-- Attachment #1.2: Type: text/html, Size: 2438 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: dmsetup arguments

[Dave Chinner]

On Fri, Jun 14, 2013 at 12:51:25PM +0400, alexander.tsvetkov@oracle.com wrote:
> Hi,
> 
> XFStests suite generic/311 test fails on command: "sbin/dmsetup load
> flakey-test --table "0 150000001 flakey /dev/sdc2 0 0 180 1
> drop_writes" with error: "device-mapper: reload ioctl on flakey-test
> failed: Invalid argument", so as I understand the command format
> provided to ioctl is incorrect here. Kernel logs has message:
> 
> "Jun 13 16:47:15 tests kernel: device-mapper: table: 252:3: flakey:
> dm-flakey: Invalid argument count
> Jun 13 16:47:15 tests kernel: device-mapper: ioctl: error adding
> target to table"

What kernel and version of dmsetup are you using? If it is too old
to support the flakey target, then we need a new require rule check
for the test to avoid old versions of dmsetup...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: dmsetup arguments

[Dave Chinner]

On Tue, Jun 18, 2013 at 04:08:44PM +0400, alexander.tsvetkov@oracle.com wrote:
> On 06/18/13 05:26, Dave Chinner wrote:
> >On Fri, Jun 14, 2013 at 12:51:25PM +0400, alexander.tsvetkov@oracle.com wrote:
> >>Hi,
> >>
> >>XFStests suite generic/311 test fails on command: "sbin/dmsetup load
> >>flakey-test --table "0 150000001 flakey /dev/sdc2 0 0 180 1
> >>drop_writes" with error: "device-mapper: reload ioctl on flakey-test
> >>failed: Invalid argument", so as I understand the command format
> >>provided to ioctl is incorrect here. Kernel logs has message:
> >>
> >>"Jun 13 16:47:15 tests kernel: device-mapper: table: 252:3: flakey:
> >>dm-flakey: Invalid argument count
> >>Jun 13 16:47:15 tests kernel: device-mapper: ioctl: error adding
> >>target to table"
> >What kernel and version of dmsetup are you using? If it is too old
> >to support the flakey target, then we need a new require rule check
> >for the test to avoid old versions of dmsetup...
>
> Kernel version is 2.6.39, version of device-mapper-libs is 1.02.77.

So it's an old version of both the kernel and DM, so it's probably
not been tested at all. Like I said - it probably needs a better
check in _require_dm_flakey() to determine if the test should be run
or not.

Patches are welcome...

Cheers,

Dave.

PS: please reply-to-all for mailing list traffic, not by private
email. I've re-added the XFS list to the CC list.

PPS: Top posting destroys the context of your reply - nobody has any
idea of what part of the previous message you are responding to.
Repsonding inline is much easier to follow with when conversions get
long...
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: dmsetup arguments

[alexander.tsvetkov]

On 06/18/13 17:23, Dave Chinner wrote:
> On Tue, Jun 18, 2013 at 04:08:44PM +0400, alexander.tsvetkov@oracle.com wrote:
>> On 06/18/13 05:26, Dave Chinner wrote:
>>> On Fri, Jun 14, 2013 at 12:51:25PM +0400, alexander.tsvetkov@oracle.com wrote:
>>>> Hi,
>>>>
>>>> XFStests suite generic/311 test fails on command: "sbin/dmsetup load
>>>> flakey-test --table "0 150000001 flakey /dev/sdc2 0 0 180 1
>>>> drop_writes" with error: "device-mapper: reload ioctl on flakey-test
>>>> failed: Invalid argument", so as I understand the command format
>>>> provided to ioctl is incorrect here. Kernel logs has message:
>>>>
>>>> "Jun 13 16:47:15 tests kernel: device-mapper: table: 252:3: flakey:
>>>> dm-flakey: Invalid argument count
>>>> Jun 13 16:47:15 tests kernel: device-mapper: ioctl: error adding
>>>> target to table"
>>> What kernel and version of dmsetup are you using? If it is too old
>>> to support the flakey target, then we need a new require rule check
>>> for the test to avoid old versions of dmsetup...
>> Kernel version is 2.6.39, version of device-mapper-libs is 1.02.77.
> So it's an old version of both the kernel and DM, so it's probably
> not been tested at all. Like I said - it probably needs a better
> check in _require_dm_flakey() to determine if the test should be run
> or not.
>
I agree about kernel version, but why DM version of 1.02.77 is also old? 
I though that I am using the latest version of DM referenced by these 
sources:

"Releases
The userspace code (dmsetup and libdevmapper) is now maintained 
alongside the LVM2 source available from http://sources.redhat.com/lvm2/."

http://www.sourceware.org/dm/

and

"Source code

The source code is stored in git and can be accessed with git clone 
git://git.fedorahosted.org/git/lvm2.git
There is a web interface to git at http://git.fedorahosted.org/git/lvm2.git"

http://sources.redhat.com/lvm2/

so finally I've got DM of version 1.02.77 within lvm2 package of version 
2.02.98 from http://git.fedorahosted.org/git/lvm2.git, it's of latest 
released version in the provided list.
Most recent lvm2 package from master branch of 2.02.99 version contains 
DM ofversion 1.02.78 which has no attribute "drop_writes" in sources as 
well.

Thanks,
Alexander Tsvetkov

> Patches are welcome...
>
> Cheers,
>
> Dave.
>
> PS: please reply-to-all for mailing list traffic, not by private
> email. I've re-added the XFS list to the CC list.
>
> PPS: Top posting destroys the context of your reply - nobody has any
> idea of what part of the previous message you are responding to.
> Repsonding inline is much easier to follow with when conversions get
> long...

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs