* [PATCH] xfs: Remove the left function variable from xfs_ialloc_get_rec()
@ 2013-06-21 12:33 Jeff Liu
2013-06-23 23:14 ` Dave Chinner
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Liu @ 2013-06-21 12:33 UTC (permalink / raw)
To: xfs@oss.sgi.com
From: Jie Liu <jeff.liu@oracle.com>
This patch clean out the left function variable as it is
useless to xfs_ialloc_get_rec().
Signed-off-by: jeff <jeff@kdev.(none)>
---
fs/xfs/xfs_ialloc.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c
index c8f5ae1..4345c53 100644
--- a/fs/xfs/xfs_ialloc.c
+++ b/fs/xfs/xfs_ialloc.c
@@ -615,8 +615,7 @@ xfs_ialloc_get_rec(
struct xfs_btree_cur *cur,
xfs_agino_t agino,
xfs_inobt_rec_incore_t *rec,
- int *done,
- int left)
+ int *done)
{
int error;
int i;
@@ -724,12 +723,12 @@ xfs_dialloc_ag(
pag->pagl_leftrec != NULLAGINO &&
pag->pagl_rightrec != NULLAGINO) {
error = xfs_ialloc_get_rec(tcur, pag->pagl_leftrec,
- &trec, &doneleft, 1);
+ &trec, &doneleft);
if (error)
goto error1;
error = xfs_ialloc_get_rec(cur, pag->pagl_rightrec,
- &rec, &doneright, 0);
+ &rec, &doneright);
if (error)
goto error1;
} else {
--
1.7.9.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: Remove the left function variable from xfs_ialloc_get_rec()
2013-06-21 12:33 [PATCH] xfs: Remove the left function variable from xfs_ialloc_get_rec() Jeff Liu
@ 2013-06-23 23:14 ` Dave Chinner
2013-06-24 3:32 ` Jeff Liu
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2013-06-23 23:14 UTC (permalink / raw)
To: Jeff Liu; +Cc: xfs@oss.sgi.com
On Fri, Jun 21, 2013 at 08:33:29PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> This patch clean out the left function variable as it is
> useless to xfs_ialloc_get_rec().
>
> Signed-off-by: jeff <jeff@kdev.(none)>
Patch looks OK, by the SOB is all wrong. can you repost with the
correct SOB?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: Remove the left function variable from xfs_ialloc_get_rec()
2013-06-23 23:14 ` Dave Chinner
@ 2013-06-24 3:32 ` Jeff Liu
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Liu @ 2013-06-24 3:32 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs@oss.sgi.com
On 06/24/2013 07:14 AM, Dave Chinner wrote:
> On Fri, Jun 21, 2013 at 08:33:29PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> This patch clean out the left function variable as it is
>> useless to xfs_ialloc_get_rec().
>>
>> Signed-off-by: jeff <jeff@kdev.(none)>
>
> Patch looks OK, by the SOB is all wrong. can you repost with the
> correct SOB?
Will repost it soon, my apologies!
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-24 3:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-21 12:33 [PATCH] xfs: Remove the left function variable from xfs_ialloc_get_rec() Jeff Liu
2013-06-23 23:14 ` Dave Chinner
2013-06-24 3:32 ` Jeff Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox