public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Stan Hoeppner <stan@hardwarefreak.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: xfs@oss.sgi.com
Subject: Re: Corruption of root fs during git bisect of drm system hang
Date: Thu, 11 Jul 2013 15:24:03 -0500	[thread overview]
Message-ID: <51DF1463.1070603@hardwarefreak.com> (raw)
In-Reply-To: <20130711112826.GA363@x4>

On 7/11/2013 6:28 AM, Markus Trippelsdorf wrote:
...
>> Looking at the source:
>> http://api.kde.org/4.10-api/kdelibs-apidocs/kdecore/html/ksavefile_8cpp_source.html#l00219
>> it appears that one can set an environment variable KDE_EXTRA_FSYNC to
>> address this issue.
>>
>> However in my case it doesn't help. Even with KDE_EXTRA_FSYNC=1 I still
>> loose my KDE settings in case of a crash. So the whole fsync thing might
>> be a red herring.
> 
> It turned out that the KDE_EXTRA_FSYNC variable doesn't affect KDE
> config file handling at all.
> So I've added an fsync in kconfigini.cpp (KConfigIniBackend::writeConfig)
> and now I don't loose my settings anymore during kernel crash testing.
> 
> That is until xfs eats my KDE config files (kwinrulesr in this case):

Adding fsync in kconfigini.cpp apparently doesn't force fsync for all
KDE file operations.  You also have some Open Office files getting hosed
due to lack of fsync.  XFS is not the cause of these problems.

The problem is that all of this desktop code was developed atop EXT3
which flushed to disk every 5 seconds.  This made programmers sloppy as
they didn't have to fsync to make sure data hit disk.  This problem has
been covered extensively by many, including Eric in other posts on his
blog.  There's a really simple way to test this:  mount with sync.
Report results after the next crash.  If no files are corrupted then
you've verified the problem lay squarely on the shoulders of these
desktop developers who have abdicated their responsibility to make sure
their file changes hit the disk, instead of relying on a broken
filesystem do it for them.

Worth noting, using EXT4 without the EXT3 flush emulation enabled will
yield similar file corruption upon a crash.

-- 
Stan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-07-11 20:24 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10  9:06 Corruption of root fs during git bisect of drm system hang Markus Trippelsdorf
2013-07-11  0:31 ` Dave Chinner
2013-07-11  3:36   ` Markus Trippelsdorf
2013-07-11  3:58     ` Dave Chinner
2013-07-11  4:12       ` Stan Hoeppner
2013-07-11  9:07         ` Markus Trippelsdorf
2013-07-11 11:28           ` Markus Trippelsdorf
2013-07-11 20:24             ` Stan Hoeppner [this message]
2013-07-11 20:40               ` Markus Trippelsdorf
2013-07-11 23:01                 ` Stan Hoeppner
2013-07-12  2:38                 ` Dave Chinner
2013-07-12  2:17           ` Dave Chinner
2013-07-12  7:07             ` Markus Trippelsdorf
2013-07-13  9:05               ` Markus Trippelsdorf
2013-07-15  2:28               ` Dave Chinner
2013-07-15  6:47                 ` Markus Trippelsdorf
2013-07-19 12:22                   ` [Bisected] " Markus Trippelsdorf
2013-07-19 12:41                     ` Stefan Ring
2013-07-19 12:51                       ` Markus Trippelsdorf
2013-07-19 16:02                         ` Eric Sandeen
2013-07-19 16:32                           ` Markus Trippelsdorf
2013-07-19 19:13                             ` Ben Myers
2013-07-19 19:56                               ` Markus Trippelsdorf
2013-07-19 20:28                                 ` Markus Trippelsdorf
2013-07-19 19:23                             ` Eric Sandeen
2013-07-19 19:53                               ` Markus Trippelsdorf
2013-07-19 21:11                     ` Mark Tinguely
2013-07-20  3:18                       ` Dave Chinner
2013-07-20 17:21                         ` Mark Tinguely
2013-07-21  7:37                           ` Dave Chinner
2013-07-20  1:48                     ` Dave Chinner
2013-07-22 10:22                       ` Dave Chinner
2013-07-22 10:47                         ` Markus Trippelsdorf
2013-07-22 22:54                           ` Dave Chinner
2013-07-11  4:15       ` Markus Trippelsdorf
2013-07-11  0:37 ` Stan Hoeppner
2013-07-11  3:47   ` Markus Trippelsdorf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DF1463.1070603@hardwarefreak.com \
    --to=stan@hardwarefreak.com \
    --cc=markus@trippelsdorf.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox