From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id BABD87F37 for ; Mon, 22 Jul 2013 08:27:45 -0500 (CDT) Message-ID: <51ED3351.5010304@sgi.com> Date: Mon, 22 Jul 2013 08:27:45 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface References: <1374215120-7271-1-git-send-email-david@fromorbit.com> <1374215120-7271-39-git-send-email-david@fromorbit.com> In-Reply-To: <1374215120-7271-39-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 07/19/13 01:25, Dave Chinner wrote: > From: Jie Liu > > With the new xfs_trans_res structure has been introduced, the log > reservation size, log count as well as log flags are pre-initialized > at mount time. So it's time to refine xfs_trans_reserve() interface > to be more neat. > > Also, introduce a new helper M_RES() to return a pointer to the > mp->m_resv structure to simplify the input. > > Signed-off-by: Jie Liu > Signed-off-by: Dave Chinner > --- > +/* shorthand way of accessing reservation structure */ > +#define M_RES(mp) (&(mp)->m_resv) Not a fan of this define- it does not buy much savings in text and clarity. Beside my anti-shouty rant, the patch looks good. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs