Re: [PATCH 45/49] xfs: avoid CIL allocation during insert

Mark Tinguely
2013-07-29T18:13:11Z

On 07/19/13 01:25, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> Now that we have the size of the log vector that has been allocated,
> we can determine if we need to allocate a new log vector for
> formatting and insertion. We only need to allocate a new vector if
> it won't fit into the existing buffer.
>
> However, we need to hold the CIL context lock while we do this so
> that we can't race with a push draining the currently queued log
> vectors. It is safe to do this as long as we do GFP_NOFS allocation
> to avoid avoid memory allocation recursing into the filesystem.
> Hence we can safely overwrite the existing log vector on the CIL if
> it is large enough to hold all the dirty regions of the current
> item.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---

back to the CIl commit opt series now that the log space leak has been
found..

Looks good - avoid allocation if dirtying existing dirty chunks. Remove
the IOP_PIN

Reviewed-by: Mark Tinguely <tinguely@sgi.com>