Re: [PATCH 20/49] xfs: introduce xfs_sb.c for sharing with libxfs

Dave Chinner
2013-07-28T01:08:37Z

On Sat, Jul 27, 2013 at 12:54:02PM -0500, Mark Tinguely wrote:
> On 07/19/13 01:24, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@redhat.com>
> >
> >xfs_mount.c is shared with userspace, but the only functions that
> >are shared are to do with physical superblock manipulations. This
> >means that less than 25% of the xfs_mount.c code is actually shared
> >with userspace. Move all the superblock functions to xfs_sb.c and
> >share that instead with libxfs.
> >
> >Note that this will leave all the in-core transaction related
> >superblock counter modifications in xfs_mount.c as none of that is
> >shared with userspace. With a few more small changes, xfs_mount.h
> >won't need to be shared with userspace anymore, either.
> >
> >Signed-off-by: Dave Chinner<dchinner@redhat.com>
> >---
>
> okay, moves the user sharable functions/headers from xfs_mount.c/h to
> xfs_sb.c/h
>
> couple comments:
>
> a struct xfs_mount got converted to a xfs_mount_t typedef in
> xfs_initialize_perag() def in xfs_mount.h
>
> brackets were added to a single line if statements in
> xfs_sb_quota_from_disk()

I'll fix those - I missed them when doing an update.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com