Re: [PATCH 41/49] xfs: Add xfs_log_rlimit.c

Mark Tinguely
2013-07-23T15:15:30Z

On 07/19/13 01:25, Dave Chinner wrote:
> From: Jie Liu<jeff.liu@oracle.com>
>
> Add source files for xfs_log_rlimit.c The new file is used for log
> size calculations and validation shared with userspace.
>
> [dchinner: xfs_log_calc_max_attrsetm_res() does not modify the
> tr_attrsetm reservation, just calculates the maximum. ]
>
> [dchinner: rework loop in xfs_log_get_max_trans_res() ]
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---

> + if (lsunit)
> + min_logblks = roundup(BTOBB(max_logres), lsunit) + 2 * lsunit;
> + else
> + min_logblks = BTOBB(max_logres);

^^ The space is not really needed when using the below multiplier, but
add the 2 * BBSIZE size just to be consistent?

> + min_logblks *= XFS_MIN_LOG_FACTOR;

^^ okay, a 3 times multiplier of the max transaction and an additional
log stripe unit padding will more than make up for all my CIL/CTX concerns.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>