Re: [PATCH 22/49] xfs: minor cleanups

Mark Tinguely
2013-07-27T18:00:43Z

On 07/19/13 01:24, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> These come from syncing the shared userspace and kernel code. Small
> whitespace and trivial cleanups.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---

okay, minor clean-ups

Don't understand the change from min_t to min:

> diff --git a/fs/xfs/xfs_attr_remote.c b/fs/xfs/xfs_attr_remote.c
> index 13a0ed9..b42926a 100644
> --- a/fs/xfs/xfs_attr_remote.c
> +++ b/fs/xfs/xfs_attr_remote.c
> @@ -251,7 +251,7 @@ xfs_attr_rmtval_copyout(
> int hdr_size = 0;
> int byte_cnt = XFS_ATTR3_RMT_BUF_SPACE(mp, XFS_LBSIZE(mp));
>
> - byte_cnt = min_t(int, *valuelen, byte_cnt);
> + byte_cnt = min(*valuelen, byte_cnt);
>
> if (xfs_sb_version_hascrc(&mp->m_sb)) {
> if (!xfs_attr3_rmt_hdr_ok(mp, src, ino, *offset,

but looks good:

Reviewed-by: Mark Tinguely <tinguely@sgi.com>