public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 07/49] xfs: split out on-disk transaction definitions
Date: Wed, 24 Jul 2013 08:09:50 -0400	[thread overview]
Message-ID: <51EFC40E.20101@redhat.com> (raw)
In-Reply-To: <1374215120-7271-8-git-send-email-david@fromorbit.com>

On 07/19/2013 02:24 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> There's a bunch of definitions in xfs_trans.h that define on-disk
> formats - transaction headers taht get written into the log, log
> item type definitions, etc. Split out everything into a separate
> file so that all which remains in xfs_trans.h are kernel only
> definitions.
> 
> Also, remove the duplicate magic number definitions for
> XFS_TRANS_HEADER_MAGIC...
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---

Removed XFS_TRANS_MAGIC, added missing XFS_LI_ICREATE description
string, otherwise code shuffling:

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  fs/xfs/xfs_log_format.h | 206 ++++++++++++++++++++++++++++++++++++++++++++++++
>  fs/xfs/xfs_trans.c      |   4 +-
>  fs/xfs/xfs_trans.h      | 205 -----------------------------------------------
>  3 files changed, 208 insertions(+), 207 deletions(-)
> 
> diff --git a/fs/xfs/xfs_log_format.h b/fs/xfs/xfs_log_format.h
> index 02639c7..faf3f43 100644
> --- a/fs/xfs/xfs_log_format.h
> +++ b/fs/xfs/xfs_log_format.h
> @@ -187,6 +187,212 @@ typedef struct xfs_log_iovec {
>  
>  
>  /*
> + * Transaction Header definitions.
> + *
> + * This is the structure written in the log at the head of every transaction. It
> + * identifies the type and id of the transaction, and contains the number of
> + * items logged by the transaction so we know how many to expect during
> + * recovery.
> + *
> + * Do not change the below structure without redoing the code in
> + * xlog_recover_add_to_trans() and xlog_recover_add_to_cont_trans().
> + */
> +typedef struct xfs_trans_header {
> +	uint		th_magic;		/* magic number */
> +	uint		th_type;		/* transaction type */
> +	__int32_t	th_tid;			/* transaction id (unused) */
> +	uint		th_num_items;		/* num items logged by trans */
> +} xfs_trans_header_t;
> +
> +#define	XFS_TRANS_HEADER_MAGIC	0x5452414e	/* TRAN */
> +
> +/*
> + * Log item types.
> + */
> +#define	XFS_LI_EFI		0x1236
> +#define	XFS_LI_EFD		0x1237
> +#define	XFS_LI_IUNLINK		0x1238
> +#define	XFS_LI_INODE		0x123b	/* aligned ino chunks, var-size ibufs */
> +#define	XFS_LI_BUF		0x123c	/* v2 bufs, variable sized inode bufs */
> +#define	XFS_LI_DQUOT		0x123d
> +#define	XFS_LI_QUOTAOFF		0x123e
> +#define	XFS_LI_ICREATE		0x123f
> +
> +#define XFS_LI_TYPE_DESC \
> +	{ XFS_LI_EFI,		"XFS_LI_EFI" }, \
> +	{ XFS_LI_EFD,		"XFS_LI_EFD" }, \
> +	{ XFS_LI_IUNLINK,	"XFS_LI_IUNLINK" }, \
> +	{ XFS_LI_INODE,		"XFS_LI_INODE" }, \
> +	{ XFS_LI_BUF,		"XFS_LI_BUF" }, \
> +	{ XFS_LI_DQUOT,		"XFS_LI_DQUOT" }, \
> +	{ XFS_LI_QUOTAOFF,	"XFS_LI_QUOTAOFF" }, \
> +	{ XFS_LI_ICREATE,	"XFS_LI_ICREATE" }
> +
> +/*
> + * Transaction types.  Used to distinguish types of buffers.
> + */
> +#define XFS_TRANS_SETATTR_NOT_SIZE	1
> +#define XFS_TRANS_SETATTR_SIZE		2
> +#define XFS_TRANS_INACTIVE		3
> +#define XFS_TRANS_CREATE		4
> +#define XFS_TRANS_CREATE_TRUNC		5
> +#define XFS_TRANS_TRUNCATE_FILE		6
> +#define XFS_TRANS_REMOVE		7
> +#define XFS_TRANS_LINK			8
> +#define XFS_TRANS_RENAME		9
> +#define XFS_TRANS_MKDIR			10
> +#define XFS_TRANS_RMDIR			11
> +#define XFS_TRANS_SYMLINK		12
> +#define XFS_TRANS_SET_DMATTRS		13
> +#define XFS_TRANS_GROWFS		14
> +#define XFS_TRANS_STRAT_WRITE		15
> +#define XFS_TRANS_DIOSTRAT		16
> +/* 17 was XFS_TRANS_WRITE_SYNC */
> +#define	XFS_TRANS_WRITEID		18
> +#define	XFS_TRANS_ADDAFORK		19
> +#define	XFS_TRANS_ATTRINVAL		20
> +#define	XFS_TRANS_ATRUNCATE		21
> +#define	XFS_TRANS_ATTR_SET		22
> +#define	XFS_TRANS_ATTR_RM		23
> +#define	XFS_TRANS_ATTR_FLAG		24
> +#define	XFS_TRANS_CLEAR_AGI_BUCKET	25
> +#define XFS_TRANS_QM_SBCHANGE		26
> +/*
> + * Dummy entries since we use the transaction type to index into the
> + * trans_type[] in xlog_recover_print_trans_head()
> + */
> +#define XFS_TRANS_DUMMY1		27
> +#define XFS_TRANS_DUMMY2		28
> +#define XFS_TRANS_QM_QUOTAOFF		29
> +#define XFS_TRANS_QM_DQALLOC		30
> +#define XFS_TRANS_QM_SETQLIM		31
> +#define XFS_TRANS_QM_DQCLUSTER		32
> +#define XFS_TRANS_QM_QINOCREATE		33
> +#define XFS_TRANS_QM_QUOTAOFF_END	34
> +#define XFS_TRANS_SB_UNIT		35
> +#define XFS_TRANS_FSYNC_TS		36
> +#define	XFS_TRANS_GROWFSRT_ALLOC	37
> +#define	XFS_TRANS_GROWFSRT_ZERO		38
> +#define	XFS_TRANS_GROWFSRT_FREE		39
> +#define	XFS_TRANS_SWAPEXT		40
> +#define	XFS_TRANS_SB_COUNT		41
> +#define	XFS_TRANS_CHECKPOINT		42
> +#define	XFS_TRANS_ICREATE		43
> +#define	XFS_TRANS_TYPE_MAX		43
> +/* new transaction types need to be reflected in xfs_logprint(8) */
> +
> +#define XFS_TRANS_TYPES \
> +	{ XFS_TRANS_SETATTR_NOT_SIZE,	"SETATTR_NOT_SIZE" }, \
> +	{ XFS_TRANS_SETATTR_SIZE,	"SETATTR_SIZE" }, \
> +	{ XFS_TRANS_INACTIVE,		"INACTIVE" }, \
> +	{ XFS_TRANS_CREATE,		"CREATE" }, \
> +	{ XFS_TRANS_CREATE_TRUNC,	"CREATE_TRUNC" }, \
> +	{ XFS_TRANS_TRUNCATE_FILE,	"TRUNCATE_FILE" }, \
> +	{ XFS_TRANS_REMOVE,		"REMOVE" }, \
> +	{ XFS_TRANS_LINK,		"LINK" }, \
> +	{ XFS_TRANS_RENAME,		"RENAME" }, \
> +	{ XFS_TRANS_MKDIR,		"MKDIR" }, \
> +	{ XFS_TRANS_RMDIR,		"RMDIR" }, \
> +	{ XFS_TRANS_SYMLINK,		"SYMLINK" }, \
> +	{ XFS_TRANS_SET_DMATTRS,	"SET_DMATTRS" }, \
> +	{ XFS_TRANS_GROWFS,		"GROWFS" }, \
> +	{ XFS_TRANS_STRAT_WRITE,	"STRAT_WRITE" }, \
> +	{ XFS_TRANS_DIOSTRAT,		"DIOSTRAT" }, \
> +	{ XFS_TRANS_WRITEID,		"WRITEID" }, \
> +	{ XFS_TRANS_ADDAFORK,		"ADDAFORK" }, \
> +	{ XFS_TRANS_ATTRINVAL,		"ATTRINVAL" }, \
> +	{ XFS_TRANS_ATRUNCATE,		"ATRUNCATE" }, \
> +	{ XFS_TRANS_ATTR_SET,		"ATTR_SET" }, \
> +	{ XFS_TRANS_ATTR_RM,		"ATTR_RM" }, \
> +	{ XFS_TRANS_ATTR_FLAG,		"ATTR_FLAG" }, \
> +	{ XFS_TRANS_CLEAR_AGI_BUCKET,	"CLEAR_AGI_BUCKET" }, \
> +	{ XFS_TRANS_QM_SBCHANGE,	"QM_SBCHANGE" }, \
> +	{ XFS_TRANS_QM_QUOTAOFF,	"QM_QUOTAOFF" }, \
> +	{ XFS_TRANS_QM_DQALLOC,		"QM_DQALLOC" }, \
> +	{ XFS_TRANS_QM_SETQLIM,		"QM_SETQLIM" }, \
> +	{ XFS_TRANS_QM_DQCLUSTER,	"QM_DQCLUSTER" }, \
> +	{ XFS_TRANS_QM_QINOCREATE,	"QM_QINOCREATE" }, \
> +	{ XFS_TRANS_QM_QUOTAOFF_END,	"QM_QOFF_END" }, \
> +	{ XFS_TRANS_SB_UNIT,		"SB_UNIT" }, \
> +	{ XFS_TRANS_FSYNC_TS,		"FSYNC_TS" }, \
> +	{ XFS_TRANS_GROWFSRT_ALLOC,	"GROWFSRT_ALLOC" }, \
> +	{ XFS_TRANS_GROWFSRT_ZERO,	"GROWFSRT_ZERO" }, \
> +	{ XFS_TRANS_GROWFSRT_FREE,	"GROWFSRT_FREE" }, \
> +	{ XFS_TRANS_SWAPEXT,		"SWAPEXT" }, \
> +	{ XFS_TRANS_SB_COUNT,		"SB_COUNT" }, \
> +	{ XFS_TRANS_CHECKPOINT,		"CHECKPOINT" }, \
> +	{ XFS_TRANS_DUMMY1,		"DUMMY1" }, \
> +	{ XFS_TRANS_DUMMY2,		"DUMMY2" }, \
> +	{ XLOG_UNMOUNT_REC_TYPE,	"UNMOUNT" }
> +
> +/*
> + * This structure is used to track log items associated with
> + * a transaction.  It points to the log item and keeps some
> + * flags to track the state of the log item.  It also tracks
> + * the amount of space needed to log the item it describes
> + * once we get to commit processing (see xfs_trans_commit()).
> + */
> +struct xfs_log_item_desc {
> +	struct xfs_log_item	*lid_item;
> +	struct list_head	lid_trans;
> +	unsigned char		lid_flags;
> +};
> +
> +#define XFS_LID_DIRTY		0x1
> +
> +/*
> + * Values for t_flags.
> + */
> +#define	XFS_TRANS_DIRTY		0x01	/* something needs to be logged */
> +#define	XFS_TRANS_SB_DIRTY	0x02	/* superblock is modified */
> +#define	XFS_TRANS_PERM_LOG_RES	0x04	/* xact took a permanent log res */
> +#define	XFS_TRANS_SYNC		0x08	/* make commit synchronous */
> +#define XFS_TRANS_DQ_DIRTY	0x10	/* at least one dquot in trx dirty */
> +#define XFS_TRANS_RESERVE	0x20    /* OK to use reserved data blocks */
> +#define XFS_TRANS_FREEZE_PROT	0x40	/* Transaction has elevated writer
> +					   count in superblock */
> +
> +/*
> + * Values for call flags parameter.
> + */
> +#define	XFS_TRANS_RELEASE_LOG_RES	0x4
> +#define	XFS_TRANS_ABORT			0x8
> +
> +/*
> + * Field values for xfs_trans_mod_sb.
> + */
> +#define	XFS_TRANS_SB_ICOUNT		0x00000001
> +#define	XFS_TRANS_SB_IFREE		0x00000002
> +#define	XFS_TRANS_SB_FDBLOCKS		0x00000004
> +#define	XFS_TRANS_SB_RES_FDBLOCKS	0x00000008
> +#define	XFS_TRANS_SB_FREXTENTS		0x00000010
> +#define	XFS_TRANS_SB_RES_FREXTENTS	0x00000020
> +#define	XFS_TRANS_SB_DBLOCKS		0x00000040
> +#define	XFS_TRANS_SB_AGCOUNT		0x00000080
> +#define	XFS_TRANS_SB_IMAXPCT		0x00000100
> +#define	XFS_TRANS_SB_REXTSIZE		0x00000200
> +#define	XFS_TRANS_SB_RBMBLOCKS		0x00000400
> +#define	XFS_TRANS_SB_RBLOCKS		0x00000800
> +#define	XFS_TRANS_SB_REXTENTS		0x00001000
> +#define	XFS_TRANS_SB_REXTSLOG		0x00002000
> +
> +/*
> + * Here we centralize the specification of XFS meta-data buffer
> + * reference count values.  This determine how hard the buffer
> + * cache tries to hold onto the buffer.
> + */
> +#define	XFS_AGF_REF		4
> +#define	XFS_AGI_REF		4
> +#define	XFS_AGFL_REF		3
> +#define	XFS_INO_BTREE_REF	3
> +#define	XFS_ALLOC_BTREE_REF	2
> +#define	XFS_BMAP_BTREE_REF	2
> +#define	XFS_DIR_BTREE_REF	2
> +#define	XFS_INO_REF		2
> +#define	XFS_ATTR_BTREE_REF	1
> +#define	XFS_DQUOT_REF		1
> +
> +/*
>   * Inode Log Item Format definitions.
>   *
>   * This is the structure used to lay out an inode log item in the
> diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
> index 1d2a061..9b70df3 100644
> --- a/fs/xfs/xfs_trans.c
> +++ b/fs/xfs/xfs_trans.c
> @@ -744,7 +744,7 @@ _xfs_trans_alloc(
>  	atomic_inc(&mp->m_active_trans);
>  
>  	tp = kmem_zone_zalloc(xfs_trans_zone, memflags);
> -	tp->t_magic = XFS_TRANS_MAGIC;
> +	tp->t_magic = XFS_TRANS_HEADER_MAGIC;
>  	tp->t_type = type;
>  	tp->t_mountp = mp;
>  	INIT_LIST_HEAD(&tp->t_items);
> @@ -789,7 +789,7 @@ xfs_trans_dup(
>  	/*
>  	 * Initialize the new transaction structure.
>  	 */
> -	ntp->t_magic = XFS_TRANS_MAGIC;
> +	ntp->t_magic = XFS_TRANS_HEADER_MAGIC;
>  	ntp->t_type = tp->t_type;
>  	ntp->t_mountp = tp->t_mountp;
>  	INIT_LIST_HEAD(&ntp->t_items);
> diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h
> index 2b49463..ffaa584 100644
> --- a/fs/xfs/xfs_trans.h
> +++ b/fs/xfs/xfs_trans.h
> @@ -21,195 +21,6 @@
>  struct xfs_log_item;
>  
>  /*
> - * This is the structure written in the log at the head of
> - * every transaction. It identifies the type and id of the
> - * transaction, and contains the number of items logged by
> - * the transaction so we know how many to expect during recovery.
> - *
> - * Do not change the below structure without redoing the code in
> - * xlog_recover_add_to_trans() and xlog_recover_add_to_cont_trans().
> - */
> -typedef struct xfs_trans_header {
> -	uint		th_magic;		/* magic number */
> -	uint		th_type;		/* transaction type */
> -	__int32_t	th_tid;			/* transaction id (unused) */
> -	uint		th_num_items;		/* num items logged by trans */
> -} xfs_trans_header_t;
> -
> -#define	XFS_TRANS_HEADER_MAGIC	0x5452414e	/* TRAN */
> -
> -/*
> - * Log item types.
> - */
> -#define	XFS_LI_EFI		0x1236
> -#define	XFS_LI_EFD		0x1237
> -#define	XFS_LI_IUNLINK		0x1238
> -#define	XFS_LI_INODE		0x123b	/* aligned ino chunks, var-size ibufs */
> -#define	XFS_LI_BUF		0x123c	/* v2 bufs, variable sized inode bufs */
> -#define	XFS_LI_DQUOT		0x123d
> -#define	XFS_LI_QUOTAOFF		0x123e
> -#define	XFS_LI_ICREATE		0x123f
> -
> -#define XFS_LI_TYPE_DESC \
> -	{ XFS_LI_EFI,		"XFS_LI_EFI" }, \
> -	{ XFS_LI_EFD,		"XFS_LI_EFD" }, \
> -	{ XFS_LI_IUNLINK,	"XFS_LI_IUNLINK" }, \
> -	{ XFS_LI_INODE,		"XFS_LI_INODE" }, \
> -	{ XFS_LI_BUF,		"XFS_LI_BUF" }, \
> -	{ XFS_LI_DQUOT,		"XFS_LI_DQUOT" }, \
> -	{ XFS_LI_QUOTAOFF,	"XFS_LI_QUOTAOFF" }
> -
> -/*
> - * Transaction types.  Used to distinguish types of buffers.
> - */
> -#define XFS_TRANS_SETATTR_NOT_SIZE	1
> -#define XFS_TRANS_SETATTR_SIZE		2
> -#define XFS_TRANS_INACTIVE		3
> -#define XFS_TRANS_CREATE		4
> -#define XFS_TRANS_CREATE_TRUNC		5
> -#define XFS_TRANS_TRUNCATE_FILE		6
> -#define XFS_TRANS_REMOVE		7
> -#define XFS_TRANS_LINK			8
> -#define XFS_TRANS_RENAME		9
> -#define XFS_TRANS_MKDIR			10
> -#define XFS_TRANS_RMDIR			11
> -#define XFS_TRANS_SYMLINK		12
> -#define XFS_TRANS_SET_DMATTRS		13
> -#define XFS_TRANS_GROWFS		14
> -#define XFS_TRANS_STRAT_WRITE		15
> -#define XFS_TRANS_DIOSTRAT		16
> -/* 17 was XFS_TRANS_WRITE_SYNC */
> -#define	XFS_TRANS_WRITEID		18
> -#define	XFS_TRANS_ADDAFORK		19
> -#define	XFS_TRANS_ATTRINVAL		20
> -#define	XFS_TRANS_ATRUNCATE		21
> -#define	XFS_TRANS_ATTR_SET		22
> -#define	XFS_TRANS_ATTR_RM		23
> -#define	XFS_TRANS_ATTR_FLAG		24
> -#define	XFS_TRANS_CLEAR_AGI_BUCKET	25
> -#define XFS_TRANS_QM_SBCHANGE		26
> -/*
> - * Dummy entries since we use the transaction type to index into the
> - * trans_type[] in xlog_recover_print_trans_head()
> - */
> -#define XFS_TRANS_DUMMY1		27
> -#define XFS_TRANS_DUMMY2		28
> -#define XFS_TRANS_QM_QUOTAOFF		29
> -#define XFS_TRANS_QM_DQALLOC		30
> -#define XFS_TRANS_QM_SETQLIM		31
> -#define XFS_TRANS_QM_DQCLUSTER		32
> -#define XFS_TRANS_QM_QINOCREATE		33
> -#define XFS_TRANS_QM_QUOTAOFF_END	34
> -#define XFS_TRANS_SB_UNIT		35
> -#define XFS_TRANS_FSYNC_TS		36
> -#define	XFS_TRANS_GROWFSRT_ALLOC	37
> -#define	XFS_TRANS_GROWFSRT_ZERO		38
> -#define	XFS_TRANS_GROWFSRT_FREE		39
> -#define	XFS_TRANS_SWAPEXT		40
> -#define	XFS_TRANS_SB_COUNT		41
> -#define	XFS_TRANS_CHECKPOINT		42
> -#define	XFS_TRANS_ICREATE		43
> -#define	XFS_TRANS_TYPE_MAX		43
> -/* new transaction types need to be reflected in xfs_logprint(8) */
> -
> -#define XFS_TRANS_TYPES \
> -	{ XFS_TRANS_SETATTR_NOT_SIZE,	"SETATTR_NOT_SIZE" }, \
> -	{ XFS_TRANS_SETATTR_SIZE,	"SETATTR_SIZE" }, \
> -	{ XFS_TRANS_INACTIVE,		"INACTIVE" }, \
> -	{ XFS_TRANS_CREATE,		"CREATE" }, \
> -	{ XFS_TRANS_CREATE_TRUNC,	"CREATE_TRUNC" }, \
> -	{ XFS_TRANS_TRUNCATE_FILE,	"TRUNCATE_FILE" }, \
> -	{ XFS_TRANS_REMOVE,		"REMOVE" }, \
> -	{ XFS_TRANS_LINK,		"LINK" }, \
> -	{ XFS_TRANS_RENAME,		"RENAME" }, \
> -	{ XFS_TRANS_MKDIR,		"MKDIR" }, \
> -	{ XFS_TRANS_RMDIR,		"RMDIR" }, \
> -	{ XFS_TRANS_SYMLINK,		"SYMLINK" }, \
> -	{ XFS_TRANS_SET_DMATTRS,	"SET_DMATTRS" }, \
> -	{ XFS_TRANS_GROWFS,		"GROWFS" }, \
> -	{ XFS_TRANS_STRAT_WRITE,	"STRAT_WRITE" }, \
> -	{ XFS_TRANS_DIOSTRAT,		"DIOSTRAT" }, \
> -	{ XFS_TRANS_WRITEID,		"WRITEID" }, \
> -	{ XFS_TRANS_ADDAFORK,		"ADDAFORK" }, \
> -	{ XFS_TRANS_ATTRINVAL,		"ATTRINVAL" }, \
> -	{ XFS_TRANS_ATRUNCATE,		"ATRUNCATE" }, \
> -	{ XFS_TRANS_ATTR_SET,		"ATTR_SET" }, \
> -	{ XFS_TRANS_ATTR_RM,		"ATTR_RM" }, \
> -	{ XFS_TRANS_ATTR_FLAG,		"ATTR_FLAG" }, \
> -	{ XFS_TRANS_CLEAR_AGI_BUCKET,	"CLEAR_AGI_BUCKET" }, \
> -	{ XFS_TRANS_QM_SBCHANGE,	"QM_SBCHANGE" }, \
> -	{ XFS_TRANS_QM_QUOTAOFF,	"QM_QUOTAOFF" }, \
> -	{ XFS_TRANS_QM_DQALLOC,		"QM_DQALLOC" }, \
> -	{ XFS_TRANS_QM_SETQLIM,		"QM_SETQLIM" }, \
> -	{ XFS_TRANS_QM_DQCLUSTER,	"QM_DQCLUSTER" }, \
> -	{ XFS_TRANS_QM_QINOCREATE,	"QM_QINOCREATE" }, \
> -	{ XFS_TRANS_QM_QUOTAOFF_END,	"QM_QOFF_END" }, \
> -	{ XFS_TRANS_SB_UNIT,		"SB_UNIT" }, \
> -	{ XFS_TRANS_FSYNC_TS,		"FSYNC_TS" }, \
> -	{ XFS_TRANS_GROWFSRT_ALLOC,	"GROWFSRT_ALLOC" }, \
> -	{ XFS_TRANS_GROWFSRT_ZERO,	"GROWFSRT_ZERO" }, \
> -	{ XFS_TRANS_GROWFSRT_FREE,	"GROWFSRT_FREE" }, \
> -	{ XFS_TRANS_SWAPEXT,		"SWAPEXT" }, \
> -	{ XFS_TRANS_SB_COUNT,		"SB_COUNT" }, \
> -	{ XFS_TRANS_CHECKPOINT,		"CHECKPOINT" }, \
> -	{ XFS_TRANS_DUMMY1,		"DUMMY1" }, \
> -	{ XFS_TRANS_DUMMY2,		"DUMMY2" }, \
> -	{ XLOG_UNMOUNT_REC_TYPE,	"UNMOUNT" }
> -
> -/*
> - * This structure is used to track log items associated with
> - * a transaction.  It points to the log item and keeps some
> - * flags to track the state of the log item.  It also tracks
> - * the amount of space needed to log the item it describes
> - * once we get to commit processing (see xfs_trans_commit()).
> - */
> -struct xfs_log_item_desc {
> -	struct xfs_log_item	*lid_item;
> -	struct list_head	lid_trans;
> -	unsigned char		lid_flags;
> -};
> -
> -#define XFS_LID_DIRTY		0x1
> -
> -#define	XFS_TRANS_MAGIC		0x5452414E	/* 'TRAN' */
> -/*
> - * Values for t_flags.
> - */
> -#define	XFS_TRANS_DIRTY		0x01	/* something needs to be logged */
> -#define	XFS_TRANS_SB_DIRTY	0x02	/* superblock is modified */
> -#define	XFS_TRANS_PERM_LOG_RES	0x04	/* xact took a permanent log res */
> -#define	XFS_TRANS_SYNC		0x08	/* make commit synchronous */
> -#define XFS_TRANS_DQ_DIRTY	0x10	/* at least one dquot in trx dirty */
> -#define XFS_TRANS_RESERVE	0x20    /* OK to use reserved data blocks */
> -#define XFS_TRANS_FREEZE_PROT	0x40	/* Transaction has elevated writer
> -					   count in superblock */
> -
> -/*
> - * Values for call flags parameter.
> - */
> -#define	XFS_TRANS_RELEASE_LOG_RES	0x4
> -#define	XFS_TRANS_ABORT			0x8
> -
> -/*
> - * Field values for xfs_trans_mod_sb.
> - */
> -#define	XFS_TRANS_SB_ICOUNT		0x00000001
> -#define	XFS_TRANS_SB_IFREE		0x00000002
> -#define	XFS_TRANS_SB_FDBLOCKS		0x00000004
> -#define	XFS_TRANS_SB_RES_FDBLOCKS	0x00000008
> -#define	XFS_TRANS_SB_FREXTENTS		0x00000010
> -#define	XFS_TRANS_SB_RES_FREXTENTS	0x00000020
> -#define	XFS_TRANS_SB_DBLOCKS		0x00000040
> -#define	XFS_TRANS_SB_AGCOUNT		0x00000080
> -#define	XFS_TRANS_SB_IMAXPCT		0x00000100
> -#define	XFS_TRANS_SB_REXTSIZE		0x00000200
> -#define	XFS_TRANS_SB_RBMBLOCKS		0x00000400
> -#define	XFS_TRANS_SB_RBLOCKS		0x00000800
> -#define	XFS_TRANS_SB_REXTENTS		0x00001000
> -#define	XFS_TRANS_SB_REXTSLOG		0x00002000
> -
> -
> -/*
>   * Per-extent log reservation for the allocation btree changes
>   * involved in freeing or allocating an extent.
>   * 2 trees * (2 blocks/level * max depth - 1)
> @@ -282,22 +93,6 @@ struct xfs_log_item_desc {
>  #define	XFS_ATTRSET_LOG_COUNT		3
>  #define	XFS_ATTRRM_LOG_COUNT		3
>  
> -/*
> - * Here we centralize the specification of XFS meta-data buffer
> - * reference count values.  This determine how hard the buffer
> - * cache tries to hold onto the buffer.
> - */
> -#define	XFS_AGF_REF		4
> -#define	XFS_AGI_REF		4
> -#define	XFS_AGFL_REF		3
> -#define	XFS_INO_BTREE_REF	3
> -#define	XFS_ALLOC_BTREE_REF	2
> -#define	XFS_BMAP_BTREE_REF	2
> -#define	XFS_DIR_BTREE_REF	2
> -#define	XFS_INO_REF		2
> -#define	XFS_ATTR_BTREE_REF	1
> -#define	XFS_DQUOT_REF		1
> -
>  #ifdef __KERNEL__
>  
>  struct xfs_buf;
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-07-24 12:13 UTC|newest]

Thread overview: 158+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  6:24 [PATCH 00/49] current patch queue for 3.12 Dave Chinner
2013-07-19  6:24 ` [PATCH 01/49] xfs: separate out log format definitions Dave Chinner
2013-07-23 14:00   ` Brian Foster
2013-07-19  6:24 ` [PATCH 02/49] xfs: split out inode log item format definition Dave Chinner
2013-07-23 14:00   ` Brian Foster
2013-07-30 16:20   ` Mark Tinguely
2013-08-01  8:50     ` Christoph Hellwig
2013-07-19  6:24 ` [PATCH 03/49] xfs: split out buf log item format definitions Dave Chinner
2013-07-23 14:01   ` Brian Foster
2013-07-19  6:24 ` [PATCH 04/49] xfs: split out inode log item format definition Dave Chinner
2013-07-23 14:01   ` Brian Foster
2013-07-19  6:24 ` [PATCH 05/49] xfs: separate dquot on disk format definitions out of xfs_quota.h Dave Chinner
2013-07-24 12:09   ` Brian Foster
2013-08-01  8:51   ` Christoph Hellwig
2013-08-02  1:44     ` Dave Chinner
2013-07-19  6:24 ` [PATCH 06/49] xfs: separate icreate log format definitions from xfs_icreate_item.h Dave Chinner
2013-07-24 12:09   ` Brian Foster
2013-07-19  6:24 ` [PATCH 07/49] xfs: split out on-disk transaction definitions Dave Chinner
2013-07-24 12:09   ` Brian Foster [this message]
2013-07-19  6:24 ` [PATCH 08/49] xfs: introduce xfs_rtalloc_defs.h Dave Chinner
2013-07-24 12:09   ` Brian Foster
2013-07-19  6:24 ` [PATCH 09/49] xfs: introduce xfs_quota_defs.h Dave Chinner
2013-07-25 12:54   ` Brian Foster
2013-07-19  6:24 ` [PATCH 10/49] xfs: sync minor header differences needed by userspace Dave Chinner
2013-07-25 12:54   ` Brian Foster
2013-07-19  6:24 ` [PATCH 11/49] xfs: split out transaction reservation code Dave Chinner
2013-07-25 12:55   ` Brian Foster
2013-07-19  6:24 ` [PATCH 12/49] xfs: move inode fork definitions to a new header file Dave Chinner
2013-07-25 20:40   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 13/49] xfs: move unrealted definitions out of xfs_inode.h Dave Chinner
2013-07-25 19:24   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations Dave Chinner
2013-07-25 19:17   ` Mark Tinguely
2013-07-26  0:24     ` Dave Chinner
2013-07-26 12:41   ` Brian Foster
2013-07-19  6:24 ` [PATCH 15/49] xfs: move getdents code into it's own file Dave Chinner
2013-07-26 13:00   ` Brian Foster
2013-07-19  6:24 ` [PATCH 16/49] xfs: reshuffle dir2 definitions around for userspace Dave Chinner
2013-07-26 13:18   ` Brian Foster
2013-07-19  6:24 ` [PATCH 17/49] xfs: split out attribute listing code into separate file Dave Chinner
2013-07-27 20:23   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 18/49] xfs: split out attribute fork truncation " Dave Chinner
2013-07-27 19:25   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 19/49] xfs: split out the remote symlink handling Dave Chinner
2013-07-27 19:48   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 20/49] xfs: introduce xfs_sb.c for sharing with libxfs Dave Chinner
2013-07-27 17:54   ` Mark Tinguely
2013-07-28  1:08     ` Dave Chinner
2013-07-19  6:24 ` [PATCH 21/49] xfs: create xfs_bmap_util.[ch] Dave Chinner
2013-07-27 17:57   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 22/49] xfs: minor cleanups Dave Chinner
2013-07-27 18:00   ` Mark Tinguely
2013-07-28  1:07     ` Dave Chinner
2013-07-19  6:24 ` [PATCH 23/49] xfs: fix issues that cause userspace warnings Dave Chinner
2013-07-27 18:02   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 24/49] xfs: kill xfs_vnodeops.[ch] Dave Chinner
2013-07-26 19:18   ` Mark Tinguely
2013-07-27  1:55     ` Dave Chinner
2013-07-27 18:58       ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 25/49] xfs: consolidate xfs_rename.c Dave Chinner
2013-07-26 19:33   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 26/49] xfs: consolidate xfs_utils.c Dave Chinner
2013-07-26 20:16   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 27/49] xfs: consolidate extent swap code Dave Chinner
2013-07-26 21:16   ` Mark Tinguely
2013-07-19  6:24 ` [PATCH 28/49] xfs: don't special case shared superblock mounts Dave Chinner
2013-07-26 15:32   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 29/49] xfs: kill __KERNEL__ check for debug code in allocation code Dave Chinner
2013-07-26 15:07   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 30/49] xfs: remove __KERNEL__ from debug code Dave Chinner
2013-07-26 15:03   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 31/49] xfs: remove __KERNEL__ check from xfs_dir2_leaf.c Dave Chinner
2013-07-26 14:16   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 32/49] xfs: xfs_filestreams.h doesn't need __KERNEL__ Dave Chinner
2013-07-26 14:10   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 33/49] xfs: move kernel specific type definitions to xfs.h Dave Chinner
2013-07-26 13:51   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 34/49] xfs: make struct xfs_perag kernel only Dave Chinner
2013-07-26 13:32   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 35/49] xfs: Introduce a new structure to hold transaction reservation items Dave Chinner
2013-07-22 13:05   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 36/49] xfs: Introduce tr_fsyncts to m_reservation Dave Chinner
2013-07-22 13:22   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 37/49] xfs: Make writeid transaction use tr_writeid Dave Chinner
2013-07-22 13:23   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 38/49] xfs: refactor xfs_trans_reserve() interface Dave Chinner
2013-07-22 13:27   ` Mark Tinguely
2013-07-22 23:37     ` Dave Chinner
2013-07-19  6:25 ` [PATCH 39/49] xfs: Get rid of all XFS_XXX_LOG_RES() macro Dave Chinner
2013-07-22 13:31   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 40/49] xfs: Refactor xfs_ticket_alloc() to extract a new helper Dave Chinner
2013-07-22 13:49   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 41/49] xfs: Add xfs_log_rlimit.c Dave Chinner
2013-07-23 15:15   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 42/49] xfs: Validate log space at mount time Dave Chinner
2013-07-22 13:55   ` Mark Tinguely
2013-07-25  4:11   ` Dave Chinner
2013-07-19  6:25 ` [PATCH 43/49] xfs: return log item size in IOP_SIZE Dave Chinner
2013-07-23 18:22   ` Mark Tinguely
2013-08-01  8:18   ` Christoph Hellwig
2013-07-19  6:25 ` [PATCH 44/49] xfs: Reduce allocations during CIL insertion Dave Chinner
2013-07-23 21:15   ` Mark Tinguely
2013-07-23 21:44     ` Michael L. Semon
2013-07-24 13:28       ` Mark Tinguely
2013-07-24 19:20         ` Michael L. Semon
2013-07-25  0:21         ` Dave Chinner
2013-07-25 15:02           ` Mark Tinguely
2013-07-26  0:32             ` Dave Chinner
2013-07-26 20:46         ` Michael L. Semon
2013-07-26 21:06           ` Mark Tinguely
2013-07-26 22:19             ` Michael L. Semon
2013-07-27  1:58             ` Dave Chinner
2013-07-27 18:32               ` Mark Tinguely
2013-07-28  1:12                 ` Dave Chinner
2013-07-29 14:15                   ` Mark Tinguely
2013-07-30  0:30                     ` Dave Chinner
2013-07-30 13:31                       ` Mark Tinguely
2013-07-30 22:19                         ` Dave Chinner
2013-07-19  6:25 ` [PATCH 45/49] xfs: avoid CIL allocation during insert Dave Chinner
2013-07-29 18:13   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 46/49] xfs: Combine CIL insert and prepare passes Dave Chinner
2013-07-23 21:21   ` Mark Tinguely
2013-07-25  0:23     ` Dave Chinner
2013-07-29 21:07   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 47/49] xfs: split the CIL lock Dave Chinner
2013-07-29 22:24   ` Mark Tinguely
2013-07-19  6:25 ` [PATCH 48/49] xfs: Add read-only support for dirent filetype field Dave Chinner
2013-07-30 19:10   ` Mark Tinguely
2013-08-12  0:59     ` ***** SUSPECTED SPAM ***** " Dave Chinner
2013-08-12 13:25       ` Mark Tinguely
2013-08-13  0:50         ` Dave Chinner
2013-08-13 15:42           ` Mark Tinguely
2013-08-13 15:57             ` Christoph Hellwig
2013-08-14  7:50             ` Dave Chinner
2013-08-14 18:47               ` Geoffrey Wehrman
2013-08-15  4:22                 ` Dave Chinner
2013-08-15 17:39                   ` Geoffrey Wehrman
2013-08-15  5:59                 ` Ric Wheeler
2013-08-15 18:04                   ` Geoffrey Wehrman
2013-08-15 21:41                     ` Ric Wheeler
2013-08-16 14:08                       ` Geoffrey Wehrman
2013-08-19  5:28                         ` Dave Chinner
2013-08-19 18:48                           ` Geoffrey Wehrman
2013-08-20  2:23                             ` Dave Chinner
2013-08-20 14:30                               ` Geoffrey Wehrman
2013-08-20 18:27                                 ` Ric Wheeler
2013-08-20 19:47                         ` Eric Sandeen
2013-08-15 16:50                 ` Eric Sandeen
2013-08-15 18:32                   ` Geoffrey Wehrman
2013-08-15 18:41                     ` Eric Sandeen
2013-08-15 19:06                       ` Geoffrey Wehrman
2013-08-15 18:54                   ` Ben Myers
2013-08-15 22:40   ` Ben Myers
2013-07-19  6:25 ` [PATCH 49/49] xfs: Add write " Dave Chinner
2013-07-21  6:23 ` [PATCH 00/49] current patch queue for 3.12 Michael L. Semon
2013-07-22 23:43   ` Dave Chinner
2013-07-23  1:00     ` Michael L. Semon
2013-08-01 21:21 ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51EFC40E.20101@redhat.com \
    --to=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox