From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 3DCF17F3F for ; Thu, 25 Jul 2013 15:40:38 -0500 (CDT) Message-ID: <51F18D42.7000503@sgi.com> Date: Thu, 25 Jul 2013 15:40:34 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 12/49] xfs: move inode fork definitions to a new header file References: <1374215120-7271-1-git-send-email-david@fromorbit.com> <1374215120-7271-13-git-send-email-david@fromorbit.com> In-Reply-To: <1374215120-7271-13-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 07/19/13 01:24, Dave Chinner wrote: > From: Dave Chinner > > The inode fork definitions are a combination of on-disk format > definition and in-memory tracking and manipulation. They are both > shared with userspace, so move them all into their own file so > sharing is easy to do and track. This removes all inode fork > related information from xfs_inode.h. > > Do the same for the all the C code that currently resides in > xfs_inode.c for the same reason. > > Signed-off-by: Dave Chinner > --- summary: Mostly a move of routines/structures from xfs_inode.c/h to xfs_inode_fork.c/h. xfs_validate_extents() is no longer a STATIC, as expected. xfs_iformat() is renamed xfs_iformat_fork(). function declarations in xfs_inode_fork.h have the typedef converted to structs. Looks good. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs