From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 5D5707F50 for ; Sat, 27 Jul 2013 13:58:35 -0500 (CDT) Message-ID: <51F4185A.6070700@sgi.com> Date: Sat, 27 Jul 2013 13:58:34 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 24/49] xfs: kill xfs_vnodeops.[ch] References: <1374215120-7271-1-git-send-email-david@fromorbit.com> <1374215120-7271-25-git-send-email-david@fromorbit.com> <51F2CB91.3020801@sgi.com> <20130727015522.GU13468@dastard> In-Reply-To: <20130727015522.GU13468@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 07/26/13 20:55, Dave Chinner wrote: > On Fri, Jul 26, 2013 at 02:18:41PM -0500, Mark Tinguely wrote: >> On 07/19/13 01:24, Dave Chinner wrote: >>> From: Dave Chinner >>> >>> Now we have xfs_inode.c for holding kernel-only XFS inode >>> operations, move all the inode operations from xfs_vnodeops.c to >>> this new file as it holds another set of kernel-only inode >>> operations. The name of this file traces back to the days of Irix >>> and it's vnodes which we don't have anymore. >>> >>> Essentially this move consolidates the inode locking functions >>> and a bunch of XFS inode operations into the one file. Eventually >>> the high level functions will be merged into the VFS interface >>> functions in xfs_iops.c. >>> >>> This leaves only internal preallocation, EOF block manipulation and >>> hole punching functions in vnodeops.c. Move these to xfs_bmap_util.c >>> where we are already consolidating various in-kernel physical extent >>> manipulation and querying functions. >>> >>> Signed-off-by: Dave Chinner >>> --- >> >> As already mentioned, xfs_inode_fork.c still has a unwanted include >> of now removed xfs_vnodeops.h. >> >> A xfs_qm_dqrele(pdqp) does not exist in the copied code: > > Yes, already fixed that here. It was causing test failures on > xfs/050. > > Cheers, > > Dave. Okay, then considered it: Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs