Re: [PATCH] xfsprogs: fix unint var in repair phase6

Mark Tinguely
2013-08-01T14:50:38Z

On 07/31/13 20:13, Eric Sandeen wrote:
> 2 calls to libxfs_bmapi_write exist in repair's phase6
> where "first" is uninitialized, but is accessed
> in that function.
>
> Normally we call xfs_bmap_init() first to initialize
> both the free list and the first block, but in these
> cases, the free list var is sent as NULL.
>
> So in these 2 cases, explicitly initialize the "first"
> variable to NULLFSBLOCK as xfs_bmap_init() does
> elsewhere.
>
> Coverity caught this.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com