From: Eric Sandeen <sandeen@redhat.com>
To: "'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>
Subject: [PATCH] xfsprogs: fix buffer leak in xlog_print_find_oldest
Date: Wed, 31 Jul 2013 20:42:58 -0500 [thread overview]
Message-ID: <51F9BD22.8060102@redhat.com> (raw)
The error path in this function did not free the buffer
before returning.
Coverity found this one.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/logprint/log_print_all.c b/logprint/log_print_all.c
index dfd76b7..d0c2959 100644
--- a/logprint/log_print_all.c
+++ b/logprint/log_print_all.c
@@ -29,7 +29,7 @@ xlog_print_find_oldest(
xfs_buf_t *bp;
xfs_daddr_t first_blk;
uint first_half_cycle, last_half_cycle;
- int error;
+ int error = 0;
if (xlog_find_zeroed(log, &first_blk))
return 0;
@@ -43,17 +43,14 @@ xlog_print_find_oldest(
last_half_cycle = xlog_get_cycle(XFS_BUF_PTR(bp));
ASSERT(last_half_cycle != 0);
- if (first_half_cycle == last_half_cycle) { /* all cycle nos are same */
+ if (first_half_cycle == last_half_cycle) /* all cycle nos are same */
*last_blk = 0;
- } else { /* have 1st and last; look for middle cycle */
+ else /* have 1st and last; look for middle cycle */
error = xlog_find_cycle_start(log, bp, first_blk,
last_blk, last_half_cycle);
- if (error)
- return error;
- }
xlog_put_bp(bp);
- return 0;
+ return error;
}
void
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2013-08-01 1:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 1:42 Eric Sandeen [this message]
2013-08-01 14:21 ` [PATCH] xfsprogs: fix buffer leak in xlog_print_find_oldest Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F9BD22.8060102@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox