From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: avoid double-free in xfs_attr_node_addname
Date: Thu, 01 Aug 2013 09:18:47 -0500 [thread overview]
Message-ID: <51FA6E47.9030607@sgi.com> (raw)
In-Reply-To: <51F9B77E.2030005@redhat.com>
On 07/31/13 20:18, Eric Sandeen wrote:
> xfs_attr_node_addname()'s error handling tests whether it
> should free "state" in the out: error handling label:
>
> out:
> if (state)
> xfs_da_state_free(state);
>
> but an earlier free doesn't set state to NULL afterwards; this
> could lead to a double free. Fix it by setting state to NULL
> after it's freed.
>
> This was found by Coverity.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> Note: Exact same patch should hit xfsprogs - I could send another,
> or maybe SGI can just apply it in both trees?
>
> Thanks,
> -Eric
Looks good. we will discuss the details at PM phone call.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-01 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 1:18 [PATCH] xfs: avoid double-free in xfs_attr_node_addname Eric Sandeen
2013-08-01 14:18 ` Mark Tinguely [this message]
2013-08-13 21:34 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA6E47.9030607@sgi.com \
--to=tinguely@sgi.com \
--cc=linux-xfs@oss.sgi.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox