[PATCH] xfsprogs: fix unint var in repair phase6

[PATCH] xfsprogs: fix unint var in repair phase6

[Eric Sandeen]

2 calls to libxfs_bmapi_write exist in repair's phase6
where "first" is uninitialized, but is accessed
in that function.

Normally we call xfs_bmap_init() first to initialize
both the free list and the first block, but in these
cases, the free list var is sent as NULL.

So in these 2 cases, explicitly initialize the "first"
variable to NULLFSBLOCK as xfs_bmap_init() does
elsewhere.

Coverity caught this.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/repair/phase6.c b/repair/phase6.c
index 5c33797..119ec3b 100644
--- a/repair/phase6.c
+++ b/repair/phase6.c
@@ -536,6 +536,7 @@ fill_rbmino(xfs_mount_t *mp)
 			error);
 	}
 
+	first = NULLFSBLOCK;
 	while (bno < mp->m_sb.sb_rbmblocks)  {
 		/*
 		 * fill the file one block at a time
@@ -605,6 +606,7 @@ fill_rsumino(xfs_mount_t *mp)
 			error);
 	}
 
+	first = NULLFSBLOCK;
 	while (bno < end_bno)  {
 		/*
 		 * fill the file one block at a time

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs: fix unint var in repair phase6

[Mark Tinguely]

On 07/31/13 20:13, Eric Sandeen wrote:
> 2 calls to libxfs_bmapi_write exist in repair's phase6
> where "first" is uninitialized, but is accessed
> in that function.
>
> Normally we call xfs_bmap_init() first to initialize
> both the free list and the first block, but in these
> cases, the free list var is sent as NULL.
>
> So in these 2 cases, explicitly initialize the "first"
> variable to NULLFSBLOCK as xfs_bmap_init() does
> elsewhere.
>
> Coverity caught this.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs