From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 90C207F52 for ; Fri, 2 Aug 2013 16:42:49 -0500 (CDT) Message-ID: <51FC27D5.4090204@sgi.com> Date: Fri, 02 Aug 2013 16:42:45 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 14/49] xfs: remove local fork format handling from xfs_bmapi_write() References: <1374216324-8781-1-git-send-email-david@fromorbit.com> <1374216324-8781-15-git-send-email-david@fromorbit.com> In-Reply-To: <1374216324-8781-15-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 07/19/13 01:44, Dave Chinner wrote: > From: Dave Chinner > > The conversion from local format to extent format requires > interpretation of the data in the fork being converted, so it cannot > be done in a generic way. It is up to the caller to convert the fork > format to extent format before calling into xfs_bmapi_write() so > format conversion can be done correctly. > > The code in xfs_bmapi_write() to convert the format is used > implicitly by the attribute and directory code, but they > specifically zero the fork size so that the conversion does not do > any allocation or manipulation. Move this conversion into the > shortform to leaf functions for the dir/attr code so the conversions > are explicitly controlled by all callers. > > Now we can remove the conversion code in xfs_bmapi_write. > > Signed-off-by: Dave Chinner > --- same as kernel commit f3508bcd which I reviewed on June 27. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs