Re: [PATCH 07/12] xfs: fix the comment of xfs_iroot_realloc()

From: Mark Tinguely <tinguely@sgi.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, xfstests <xfs@oss.sgi.com>
Subject: Re: [PATCH 07/12] xfs: fix the comment of xfs_iroot_realloc()
Date: Wed, 07 Aug 2013 09:30:02 -0500	[thread overview]
Message-ID: <520259EA.1050801@sgi.com> (raw)
In-Reply-To: <CAEH94LixsQOOGpcuyMNOxi+_FscL5sE8Q2KoPYgdf0JESnPaSA@mail.gmail.com>

On 08/07/13 09:01, Zhi Yong Wu wrote:
> On Wed, Aug 7, 2013 at 9:29 PM, Mark Tinguely<tinguely@sgi.com>  wrote:
>> On 08/07/13 05:11, zwu.kernel@gmail.com wrote:
>>>
>>> From: Zhi Yong Wu<wuzhy@linux.vnet.ibm.com>
>>>
>>> Signed-off-by: Zhi Yong Wu<wuzhy@linux.vnet.ibm.com>
>>> ---
>>>    fs/xfs/xfs_inode.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
>>> index bb262c2..ccca9cd 100644
>>> --- a/fs/xfs/xfs_inode.c
>>> +++ b/fs/xfs/xfs_inode.c
>>> @@ -2103,7 +2103,7 @@ xfs_ifree(
>>>     *
>>>     * The caller must not request to add more records than would fit in
>>>     * the on-disk inode root.  If the if_broot is currently NULL, then
>>> - * if we adding records one will be allocated.  The caller must also
>>> + * if we are adding records, one will be allocated.  The caller must also
>>>     * not request that the number of records go below zero, although
>>>     * it can go to zero.
>>>     *
>>
>>
>>
>> Change this to xfs_inode_fork.c and the series will apply on top of Dave's
>> "current patch queue for Linux 3.12":
> Do you mean that you have done this or i need to do this? If i need to do this,
> can you let me know where i can get xfs git repo which has applied
> Dave's patchset?
>
>>
>>    http://oss.sgi.com/archives/xfs/2013-07/msg00411.html

If approved, we can make the change on commit.

The patches look okay to me.

--Mark.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs