From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: call roundup_64() to calculate the min_logblks
Date: Tue, 13 Aug 2013 15:51:37 +0800 [thread overview]
Message-ID: <5209E589.7080304@oracle.com> (raw)
In-Reply-To: <20130813065355.GB6023@dastard>
On 08/13/2013 02:53 PM, Dave Chinner wrote:
> On Tue, Aug 13, 2013 at 01:32:00PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Replace roundup() with roundup_64() as we calculate min_logblks
>> with 64-bit divisions. Hence, call roundup() will cause the
>> following error while compiling a 32-bit kernel:
>>
>> fs/built-in.o: In function `xfs_log_calc_minimum_size':
>> fs/xfs/xfs_log_rlimit.c:140: undefined reference to `__udivdi3'
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Cc: Dave Chinner <dchinner@redhat.com>
>> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
>
> You beat me to it, Jeff. I got an email from Fengguang's build farm,
> too. :)
Hi Dave,
I'm on a longer vacations these days(until next week). I have asked
my friend for help checking our mailing list to watch if there's any
email for me before the leaving, so I got his phone call this morning
for this bug. :)
>
> Your fix looks good.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
Thanks for your quick review!
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-13 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 5:32 [PATCH] xfs: call roundup_64() to calculate the min_logblks Jeff Liu
2013-08-13 6:53 ` Dave Chinner
2013-08-13 7:51 ` Jeff Liu [this message]
2013-08-13 15:12 ` Eric Sandeen
2013-08-13 20:44 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5209E589.7080304@oracle.com \
--to=jeff.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox