From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 7D02D7F51 for ; Tue, 13 Aug 2013 08:37:47 -0500 (CDT) Message-ID: <520A36AB.1070607@sgi.com> Date: Tue, 13 Aug 2013 08:37:47 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 45/50] xfs: avoid CIL allocation during insert References: <1376304611-22994-1-git-send-email-david@fromorbit.com> <1376304611-22994-46-git-send-email-david@fromorbit.com> In-Reply-To: <1376304611-22994-46-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 08/12/13 05:50, Dave Chinner wrote: > From: Dave Chinner > > Now that we have the size of the log vector that has been allocated, > we can determine if we need to allocate a new log vector for > formatting and insertion. We only need to allocate a new vector if > it won't fit into the existing buffer. > > However, we need to hold the CIL context lock while we do this so > that we can't race with a push draining the currently queued log > vectors. It is safe to do this as long as we do GFP_NOFS allocation > to avoid avoid memory allocation recursing into the filesystem. > Hence we can safely overwrite the existing log vector on the CIL if > it is large enough to hold all the dirty regions of the current > item. > > Signed-off-by: Dave Chinner > --- Looks good. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs