From: Eric Sandeen <sandeen@sandeen.net>
To: Mark Tinguely <tinguely@sgi.com>
Cc: "'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>,
Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
Date: Wed, 21 Aug 2013 10:28:42 -0500 [thread overview]
Message-ID: <5214DCAA.9090703@sandeen.net> (raw)
In-Reply-To: <5214CE82.3040707@sgi.com>
On 8/21/13 9:28 AM, Mark Tinguely wrote:
> On 08/20/13 18:14, Eric Sandeen wrote:
>> 3ac87fbf xfsprogs: fix inode crash in xfs_repair
>>
>> un-static'd alloc_ex_data and used it in phase6.c,
>> but didn't put a prototype in a header, so:
>>
>> phase6.c: In function ‘mk_orphanage’:
>> phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
>>
>> Fix it...
>>
>> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
>> ---
>
>
> Thanks and sorry. I knew it and hoped to get it in before it got committed.
Eh, it happens.
Minor demerit for Rich for not catching it before commit, either ;)
-Eric (who has never, NEVER made a mistake like that)
>
> --Mark.
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-21 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 23:14 [PATCH] xfs_repair: add prototype for alloc_ex_data() Eric Sandeen
2013-08-21 0:07 ` Dave Chinner
2013-08-21 14:28 ` Mark Tinguely
2013-08-21 15:28 ` Eric Sandeen [this message]
2013-08-21 17:14 ` Rich Johnston
2013-08-21 17:01 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214DCAA.9090703@sandeen.net \
--to=sandeen@sandeen.net \
--cc=linux-xfs@oss.sgi.com \
--cc=sandeen@redhat.com \
--cc=tinguely@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox