From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_db: add header to freesp -d output
Date: Thu, 22 Aug 2013 09:05:30 -0500 [thread overview]
Message-ID: <52161AAA.1070107@sgi.com> (raw)
In-Reply-To: <521541EF.1000604@redhat.com>
On 08/21/13 17:40, Eric Sandeen wrote:
> Today, xfs_db's freesp -d command dumps out a bunch of numbers:
>
> # xfs_db -c "freesp -d" /dev/sdb1
> 0 4 1
> 0 5 1
> 0 6 1
> 0 7 1
> 0 12 174772
> ...
>
> which are not useful to the non-code-reading user.
> Add some headers:
>
> # xfs_db -c "freesp -d" /dev/sdb1
> agno agbno len
> 0 4 1
> 0 5 1
> 0 6 1
> 0 7 1
> 0 12 174772
> ...
>
> so there's at least some context.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> p.s. - If folks want different strings, I'm game.
Seems like just yesterday, some reviewer was concerned about the
verbosity of table headers... wait it was yesterday! Gawd, I love irony.
:)
Geoffrey comment len -> length is fine too.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-22 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 22:40 [PATCH] xfs_db: add header to freesp -d output Eric Sandeen
2013-08-22 14:03 ` Geoffrey Wehrman
2013-08-22 14:05 ` Mark Tinguely [this message]
2013-08-22 15:30 ` Eric Sandeen
2013-08-27 18:56 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52161AAA.1070107@sgi.com \
--to=tinguely@sgi.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox