[PATCH] xfs_db: add header to freesp -d output

[PATCH] xfs_db: add header to freesp -d output

[Eric Sandeen]

Today, xfs_db's freesp -d command dumps out a bunch of numbers:

# xfs_db -c "freesp -d" /dev/sdb1
       0        4        1
       0        5        1
       0        6        1
       0        7        1
       0       12   174772
...

which are not useful to the non-code-reading user.
Add some headers:

# xfs_db -c "freesp -d" /dev/sdb1
    agno    agbno      len
       0        4        1
       0        5        1
       0        6        1
       0        7        1
       0       12   174772
...

so there's at least some context.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

p.s. - If folks want different strings, I'm game.

diff --git a/db/freesp.c b/db/freesp.c
index 6f69eba..361fa96 100644
--- a/db/freesp.c
+++ b/db/freesp.c
@@ -96,6 +96,10 @@ freesp_f(
 
 	if (!init(argc, argv))
 		return 0;
+
+	if (dumpflag)
+		dbprintf("%8s %8s %8s\n", "agno", "agbno", "len");
+
 	for (agno = 0; agno < mp->m_sb.sb_agcount; agno++)  {
 		if (inaglist(agno))
 			scan_ag(agno);

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_db: add header to freesp -d output

[Geoffrey Wehrman]

On Wed, Aug 21, 2013 at 05:40:47PM -0500, Eric Sandeen wrote:
| Today, xfs_db's freesp -d command dumps out a bunch of numbers:
| 
| # xfs_db -c "freesp -d" /dev/sdb1
|        0        4        1
|        0        5        1
|        0        6        1
|        0        7        1
|        0       12   174772
| ...
| 
| which are not useful to the non-code-reading user.
| Add some headers:
| 
| # xfs_db -c "freesp -d" /dev/sdb1
|     agno    agbno      len
|        0        4        1
|        0        5        1
|        0        6        1
|        0        7        1
|        0       12   174772
| ...
| 
| so there's at least some context.
| 
| Signed-off-by: Eric Sandeen <sandeen@redhat.com>
| ---
| 
| p.s. - If folks want different strings, I'm game.

The format is consistent with the "dumpflag" format in addtohist().  I
like your choice of strings, except I suggest "length" in place of
"len".  The space is available.


-- 
Geoffrey Wehrman  651-683-5496  gwehrman@sgi.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_db: add header to freesp -d output

[Mark Tinguely]

On 08/21/13 17:40, Eric Sandeen wrote:
> Today, xfs_db's freesp -d command dumps out a bunch of numbers:
>
> # xfs_db -c "freesp -d" /dev/sdb1
>         0        4        1
>         0        5        1
>         0        6        1
>         0        7        1
>         0       12   174772
> ...
>
> which are not useful to the non-code-reading user.
> Add some headers:
>
> # xfs_db -c "freesp -d" /dev/sdb1
>      agno    agbno      len
>         0        4        1
>         0        5        1
>         0        6        1
>         0        7        1
>         0       12   174772
> ...
>
> so there's at least some context.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> p.s. - If folks want different strings, I'm game.


Seems like just yesterday, some reviewer was concerned about the 
verbosity of table headers... wait it was yesterday! Gawd, I love irony.
:)

Geoffrey comment len -> length is fine too.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_db: add header to freesp -d output

[Eric Sandeen]

On 8/22/13 9:05 AM, Mark Tinguely wrote:
> On 08/21/13 17:40, Eric Sandeen wrote:
>> Today, xfs_db's freesp -d command dumps out a bunch of numbers:
>>
>> # xfs_db -c "freesp -d" /dev/sdb1
>>         0        4        1
>>         0        5        1
>>         0        6        1
>>         0        7        1
>>         0       12   174772
>> ...
>>
>> which are not useful to the non-code-reading user.
>> Add some headers:
>>
>> # xfs_db -c "freesp -d" /dev/sdb1
>>      agno    agbno      len
>>         0        4        1
>>         0        5        1
>>         0        6        1
>>         0        7        1
>>         0       12   174772
>> ...
>>
>> so there's at least some context.
>>
>> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
>> ---
>>
>> p.s. - If folks want different strings, I'm game.
> 
> 
> Seems like just yesterday, some reviewer was concerned about the verbosity of table headers... wait it was yesterday! Gawd, I love irony.
> :)

I'd submit that this case is a bit different - there is no context whatsoever to the table of numbers, and there will almost certainly be a very high data::header ratio.  :)

> Geoffrey comment len -> length is fine too.
> 
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>

Thanks for the review,

-Eric

> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_db: add header to freesp -d output

[Rich Johnston]

Thanks Eric, this has been committed.

--Rich

commit 982e5c7e57eaedd81984e3da6cb8ffae726dc704
Author: Eric Sandeen <sandeen@redhat.com>
Date:   Wed Aug 21 22:40:47 2013 +0000

     xfs_db: add header to freesp -d output  		

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs