From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id DE1D47FB1 for ; Thu, 22 Aug 2013 09:05:30 -0500 (CDT) Message-ID: <52161AAA.1070107@sgi.com> Date: Thu, 22 Aug 2013 09:05:30 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH] xfs_db: add header to freesp -d output References: <521541EF.1000604@redhat.com> In-Reply-To: <521541EF.1000604@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs-oss On 08/21/13 17:40, Eric Sandeen wrote: > Today, xfs_db's freesp -d command dumps out a bunch of numbers: > > # xfs_db -c "freesp -d" /dev/sdb1 > 0 4 1 > 0 5 1 > 0 6 1 > 0 7 1 > 0 12 174772 > ... > > which are not useful to the non-code-reading user. > Add some headers: > > # xfs_db -c "freesp -d" /dev/sdb1 > agno agbno len > 0 4 1 > 0 5 1 > 0 6 1 > 0 7 1 > 0 12 174772 > ... > > so there's at least some context. > > Signed-off-by: Eric Sandeen > --- > > p.s. - If folks want different strings, I'm game. Seems like just yesterday, some reviewer was concerned about the verbosity of table headers... wait it was yesterday! Gawd, I love irony. :) Geoffrey comment len -> length is fine too. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs