From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 540E629DFB for ; Fri, 23 Aug 2013 08:26:14 -0500 (CDT) Message-ID: <521762F4.4050603@sgi.com> Date: Fri, 23 Aug 2013 08:26:12 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH] xfs_io: v7 add the lseek() SEEK_DATA/SEEK_HOLE support References: <20130822213148.224998379@sgi.com> <52169488.2040303@sandeen.net> In-Reply-To: <52169488.2040303@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Rich Johnston , xfs@oss.sgi.com On 08/22/13 17:45, Eric Sandeen wrote: > On 8/22/13 4:31 PM, Mark Tinguely wrote: > >> Add the lseek SEEK_DATA/SEEK_HOLE support into xfs_io. >> The result from the lseek() call will be printed to the output. >> For example: >> >> xfs_io> seek -h 609k >> HOLE 630784 >> >> Signed-off-by: Mark Tinguely >> --- >> version 7 or 8 - Eric what number is this? > > Go for 13, for luck! > > I think this looks ok, I won't torture you any longer. If there's anything > to fix up when it really gets used in earnest we can do it then. > > (it crossed my mind that for the "-r" and "-a" invocations it might be good to print > out the offset which was sent for each SEEK_* "whence," but *shrug*) > > Thanks for all the iterations, > > Reviewed-by: Eric Sandeen Rich, hold off on commit, I can quickly add the whence. We can see how she sails. --Mark _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs