From: Rich Johnston <rjohnston@sgi.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_io: v7 add the lseek() SEEK_DATA/SEEK_HOLE support
Date: Fri, 23 Aug 2013 08:28:32 -0500 [thread overview]
Message-ID: <52176380.9070806@sgi.com> (raw)
In-Reply-To: <521762F4.4050603@sgi.com>
On 08/23/2013 08:26 AM, Mark Tinguely wrote:
> On 08/22/13 17:45, Eric Sandeen wrote:
>> On 8/22/13 4:31 PM, Mark Tinguely wrote:
>>
>>> Add the lseek SEEK_DATA/SEEK_HOLE support into xfs_io.
>>> The result from the lseek() call will be printed to the output.
>>> For example:
>>>
>>> xfs_io> seek -h 609k
>>> HOLE 630784
>>>
>>> Signed-off-by: Mark Tinguely<tinguely@sgi.com>
>>> ---
>>> version 7 or 8 - Eric what number is this?
>>
>> Go for 13, for luck!
>>
>> I think this looks ok, I won't torture you any longer. If there's
>> anything
>> to fix up when it really gets used in earnest we can do it then.
>>
>> (it crossed my mind that for the "-r" and "-a" invocations it might be
>> good to print
>> out the offset which was sent for each SEEK_* "whence," but *shrug*)
>>
>> Thanks for all the iterations,
>>
>> Reviewed-by: Eric Sandeen<sandeen@redhat.com>
>
> Rich, hold off on commit, I can quickly add the whence. We can see how
> she sails.
>
> --Mark
>
OK
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-23 13:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 21:31 [PATCH] xfs_io: v7 add the lseek() SEEK_DATA/SEEK_HOLE support Mark Tinguely
2013-08-22 22:45 ` Eric Sandeen
2013-08-23 13:26 ` Mark Tinguely
2013-08-23 13:28 ` Rich Johnston [this message]
2013-08-23 13:34 ` Eric Sandeen
2013-08-23 14:57 ` Mark Tinguely
2013-08-23 15:07 ` Eric Sandeen
2013-08-23 15:18 ` Mark Tinguely
2013-08-23 15:39 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52176380.9070806@sgi.com \
--to=rjohnston@sgi.com \
--cc=sandeen@sandeen.net \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox