Re: [PATCH] xfs_io: v7 add the lseek() SEEK_DATA/SEEK_HOLE support

Mark Tinguely
2013-08-23T13:26:14Z

On 08/22/13 17:45, Eric Sandeen wrote:
> On 8/22/13 4:31 PM, Mark Tinguely wrote:
>
>> Add the lseek SEEK_DATA/SEEK_HOLE support into xfs_io.
>> The result from the lseek() call will be printed to the output.
>> For example:
>>
>> xfs_io> seek -h 609k
>> HOLE 630784
>>
>> Signed-off-by: Mark Tinguely<tinguely@sgi.com>
>> ---
>> version 7 or 8 - Eric what number is this?
>
> Go for 13, for luck!
>
> I think this looks ok, I won't torture you any longer. If there's anything
> to fix up when it really gets used in earnest we can do it then.
>
> (it crossed my mind that for the "-r" and "-a" invocations it might be good to print
> out the offset which was sent for each SEEK_* "whence," but *shrug*)
>
> Thanks for all the iterations,
>
> Reviewed-by: Eric Sandeen<sandeen@redhat.com>

Rich, hold off on commit, I can quickly add the whence. We can see how
she sails.

--Mark