From: Eric Sandeen <sandeen@redhat.com>
To: chandan <chandan@linux.vnet.ibm.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
sekharan@linux.vnet.ibm.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: _test_generic_punch: Obtain block size from $TEST_DIR
Date: Wed, 28 Aug 2013 11:32:14 -0500 [thread overview]
Message-ID: <521E260E.4020005@redhat.com> (raw)
In-Reply-To: <2632380.gCujKLhaaV@localhost.localdomain>
On 8/28/13 1:24 AM, chandan wrote:
> The current code incorrectly gets block size information from $TEST_DEV
> instead of from $TEST_DIR. This returns the block size of the filesystem
> hosting the device file rather than that of the filesystem on $TEST_DEV.
>
> Signed-off-by: chandan <chandan@linux.vnet.ibm.com>
Oof, yes, this looks right. Seems strange, I thought < 4k was working
on x86; maybe just by accident.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
I'll take another look at your other patch in light of this fix.
Thanks!
-Eric
> ---
> common/punch | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/punch b/common/punch
> index 7b3c009..a49638c 100644
> --- a/common/punch
> +++ b/common/punch
> @@ -520,7 +520,7 @@ _test_generic_punch()
> if [ "$remove_testfile" ]; then
> rm -f $testfile
> fi
> - block_size=`stat -f $TEST_DEV | grep "Block size" | cut -d " " -f3`
> + block_size=`stat -f $TEST_DIR | grep "Block size" | cut -d " " -f3`
> $XFS_IO_PROG -f -c "truncate $block_size" \
> -c "pwrite 0 $block_size" $sync_cmd \
> -c "$zero_cmd 128 128" \
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-28 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 6:24 [PATCH] xfstests: _test_generic_punch: Obtain block size from $TEST_DIR chandan
2013-08-28 16:32 ` Eric Sandeen [this message]
2013-08-29 15:48 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521E260E.4020005@redhat.com \
--to=sandeen@redhat.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=sandeen@sandeen.net \
--cc=sekharan@linux.vnet.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox