From: Eric Sandeen <sandeen@sandeen.net>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] mkfs: add noalign option to usage()
Date: Thu, 29 Aug 2013 11:34:54 -0500 [thread overview]
Message-ID: <521F782E.2030400@sandeen.net> (raw)
In-Reply-To: <1377792190-21220-1-git-send-email-cmaiolino@redhat.com>
On 8/29/13 11:03 AM, Carlos Maiolino wrote:
> Although it has been added to manpage, there is no information about the
> existence of noalign option into the usage().
>
> Changelog:
>
> V2: Remove space in comma separated options
>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> mkfs/xfs_mkfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 4bdacee..ef1d758 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3033,7 +3033,7 @@ usage( void )
> /* metadata */ [-m crc=[0|1]\n\
> /* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
> (sunit=value,swidth=value|su=num,sw=num),\n\
> - sectlog=n|sectsize=num\n\
> + noalign,sectlog=n|sectsize=num\n\
I'd really rather see it as I suggested, for clarity.
su/sw vs. sunit/swidth vs. noalign are mutually exclusive.
su/sw & sunit/swidth are shown to be so via the (A|B) notation.
Adding noalign outside the (A|B) makes it look like it can be specified in
addition to alignment options, which really makes no sense.
Can you do:
- (sunit=value,swidth=value|su=num,sw=num),\n\
+ (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
instead?
-Eric
> /* force overwrite */ [-f]\n\
> /* inode size */ [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> projid32bit=0|1]\n\
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-29 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 16:03 [PATCH v2] mkfs: add noalign option to usage() Carlos Maiolino
2013-08-29 16:34 ` Eric Sandeen [this message]
2013-08-30 17:03 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F782E.2030400@sandeen.net \
--to=sandeen@sandeen.net \
--cc=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox