From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 30C257F67 for ; Thu, 29 Aug 2013 11:35:00 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 0E919304048 for ; Thu, 29 Aug 2013 09:34:56 -0700 (PDT) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id RqMgNIW0bYMJFTAX for ; Thu, 29 Aug 2013 09:34:55 -0700 (PDT) Message-ID: <521F782E.2030400@sandeen.net> Date: Thu, 29 Aug 2013 11:34:54 -0500 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH v2] mkfs: add noalign option to usage() References: <1377792190-21220-1-git-send-email-cmaiolino@redhat.com> In-Reply-To: <1377792190-21220-1-git-send-email-cmaiolino@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Carlos Maiolino Cc: xfs@oss.sgi.com On 8/29/13 11:03 AM, Carlos Maiolino wrote: > Although it has been added to manpage, there is no information about the > existence of noalign option into the usage(). > > Changelog: > > V2: Remove space in comma separated options > > Signed-off-by: Carlos Maiolino > --- > mkfs/xfs_mkfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > index 4bdacee..ef1d758 100644 > --- a/mkfs/xfs_mkfs.c > +++ b/mkfs/xfs_mkfs.c > @@ -3033,7 +3033,7 @@ usage( void ) > /* metadata */ [-m crc=[0|1]\n\ > /* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\ > (sunit=value,swidth=value|su=num,sw=num),\n\ > - sectlog=n|sectsize=num\n\ > + noalign,sectlog=n|sectsize=num\n\ I'd really rather see it as I suggested, for clarity. su/sw vs. sunit/swidth vs. noalign are mutually exclusive. su/sw & sunit/swidth are shown to be so via the (A|B) notation. Adding noalign outside the (A|B) makes it look like it can be specified in addition to alignment options, which really makes no sense. Can you do: - (sunit=value,swidth=value|su=num,sw=num),\n\ + (sunit=value,swidth=value|su=num,sw=num|noalign),\n\ instead? -Eric > /* force overwrite */ [-f]\n\ > /* inode size */ [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\ > projid32bit=0|1]\n\ > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs