From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 57F7E29DFC for ; Thu, 5 Sep 2013 09:35:46 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 33DF4304066 for ; Thu, 5 Sep 2013 07:35:46 -0700 (PDT) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by cuda.sgi.com with ESMTP id Y9votJiNt02THLO7 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 05 Sep 2013 07:35:44 -0700 (PDT) Message-ID: <5228963B.9010404@oracle.com> Date: Thu, 05 Sep 2013 18:33:31 +0400 From: Vasily Isaenko MIME-Version: 1.0 Subject: Re: SGID inheritance in different file-systems References: <52208DC0.2030805@oracle.com> <52289569.1070107@sandeen.net> In-Reply-To: <52289569.1070107@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="windows-1252"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs@oss.sgi.com Hi Eric, On 09/05/2013 06:30 PM, Eric Sandeen wrote: > On 8/30/13 7:19 AM, Vasily Isaenko wrote: >> Dear XFS Members, >> >> In the XFS test suite there is a test case generic/314 "Test SGID inheri= tance on subdirectories". >> It is not specific to a particular filesystem thus selected for both xfs= or ext4 test runs. >> In other words, the same behaviour is expected and enforced for XFS and = EXT4. > Yep, and it passes on both of them, as well as on ext3, ext2, btrfs, and = gfs2... > >> However, I have been told that EXT4 and XFS may have different behaviour= as the >> setgid-directory behavior is not guaranteed to work the same way on all = filesystems. > "I have been told" ... I'm guessing that you have tested a filesystem whi= ch doesn't > behave this way? Which one? yes, the generic/314 test has failed on xfs while passed on ext4 though. if this is intentional behaviour on xfs it is fine, but would it be = possible to make this test skipped on xfs then? Thank you, Vasily > >> Shall XFS test case reflect that difference or enforcing the same behavi= our is appropriate? > If you have information that a filesystem exists which does not inherit S= GID, and > that this behavior is intentional and correct and standards-compliant, th= en feel > free to submit a patch. > > However, I think you'll need to have a convincing argument against the ma= n pages. > > chmod(2) says: > > S_ISGID (02000) set-group-ID (set process effective gro= up ID on > execve(2); mandatory locking, as described in = fcntl(2); > take a new file=92s group from parent di= rectory, as > described in chown(2) and mkdir(2)) > > mkdir(2) says: > > The newly created directory will be owned by the effective user I= D of the > process. If the directory containing the file has the set-gr= oup-ID bit > set, or if the file system is mounted with BSD group semantics = (mount -o > bsdgroups or, synonymously mount -o grpid), the new directory wi= ll inherit > the group ownership from its parent; otherwise it will be owne= d by the > effective group ID of the process. > > and chown(2) says: > > NOTES > When a new file is created (by, for example, open(2) or mkdi= r(2)), its > owner is made the same as the file system user ID of the creating= process. > The group of the file depends on a range of factors, including t= he type of > file system, the options used to mount the file system, and wheth= er or not > the set-group-ID permission bit is enabled on the parent director= y. If the > file system supports the -o grpid (or, synonymously -o bsdgr= oups) and > -o nogrpid (or, synonymously -o sysvgroups) mount(8) options= , then the > rules are as follows: > > * If the file system is mounted with -o grpid, then the group of = a new file > is made the same as that of the parent directory. > > * If the file system is mounted with -o nogrpid and the set-group= -ID bit is > disabled on the parent directory, then the group of a new file= is made > the same as the process=92s file system GID. > > * If the file system is mounted with -o nogrpid and the set-group= -ID bit is > enabled on the parent directory, then the group of a new file i= s made the > same as that of the parent directory. > > Thanks, > Eric > >> Best regards, >> Vasily >> >> _______________________________________________ >> xfs mailing list >> xfs@oss.sgi.com >> http://oss.sgi.com/mailman/listinfo/xfs >> > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs