From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 381107F50 for ; Fri, 6 Sep 2013 12:29:39 -0500 (CDT) Message-ID: <522A1102.60006@sgi.com> Date: Fri, 06 Sep 2013 12:29:38 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 38/55] xfs: remove __KERNEL__ check from xfs_dir2_leaf.c References: <1378332359-14737-1-git-send-email-david@fromorbit.com> <1378332359-14737-39-git-send-email-david@fromorbit.com> In-Reply-To: <1378332359-14737-39-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 09/04/13 17:05, Dave Chinner wrote: > From: Dave Chinner > > It's actually an ifndef section, which means it is only included in > userspace. however, it's deep within the libxfs code, so it's > unlikely that the condition checked in userspace can actually occur > (search an empty leaf) through the libxfs interfaces. i.e. if it can > happen in usrspace, it can happen in the kernel, so remove it from > userspace too.... > > Signed-off-by: Dave Chinner > --- user equivalent of the for Linux 3.12 kernel patch 31/50. Looks good to me. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs