From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id B232429DFB for ; Fri, 6 Sep 2013 13:23:17 -0500 (CDT) Message-ID: <522A1D94.2070106@sgi.com> Date: Fri, 06 Sep 2013 13:23:16 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 47/55] xfs: Add read-only support for dirent filetype field References: <1378332359-14737-1-git-send-email-david@fromorbit.com> <1378332359-14737-48-git-send-email-david@fromorbit.com> In-Reply-To: <1378332359-14737-48-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 09/04/13 17:05, Dave Chinner wrote: > From: Dave Chinner > > Add support for the file type field in directory entries so that > readdir can return the type of the inode the dirent points to to > userspace without first having to read the inode off disk. > > The encoding of the type field is a single byte that is added to the > end of the directory entry name length. For all intents and > purposes, it appends a "hidden" byte to the name field which > contains the type information. As the directory entry is already of > dynamic size, helpers are already required to access and decode the > direct entry structures. > > Hence the relevent extraction and iteration helpers are updated to > understand the hidden byte. Helpers for reading and writing the > filetype field from the directory entries are also added. Only the > read helpers are used by this patch. It also adds all the code > necessary to read the type information out of the dirents on disk. > > Further we add the superblock feature bit and helpers to indicate > that we understand the on-disk format change. This is not a > compatible change - existing kernels cannot read the new format > successfully - so an incompatible feature flag is added. We don't > yet allow filesystems to mount with this flag yet - that will be > added once write support is added. > > Finally, the code to take the type from the VFS, convert it to an > XFS on-disk type and put it into the xfs_name structures passed > around is added, but the directory code does not use this field yet. > That will be in the next patch. > > Signed-off-by: Dave Chinner > --- Looks good. Same as kernel Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs