From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Greg Banks <gbanks@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: change the immutable in xfs_open_by_handle
Date: Wed, 11 Sep 2013 09:22:46 -0500 [thread overview]
Message-ID: <52307CB6.3060506@sgi.com> (raw)
In-Reply-To: <20130911135502.GA21898@infradead.org>
On 09/11/13 08:55, Christoph Hellwig wrote:
> On Tue, Sep 10, 2013 at 01:47:20PM -0500, Mark Tinguely wrote:
>> This patch allows clients like DMF to modify an immutable file
>> without changing the immutable capability on the file, which
>> would expose the file to change.
>>
>> This patch is restricted to holders of the CAP_LINUX_IMMUTABLE,
>> so no addition security risk has been introduced.
>
> The immutable flag means that the file can't be modified, and
> CAP_LINUX_IMMUTABLE allows setting/removing that restriction, but not
> ignoring it.
>
> So: NAK, this is a change in semantics and long-standing behaviour.
>
As you said, the CAP_LINUX_IMMUTABLE allows the holder of the capability
to turn on/off the restriction. The holder of CAP_LINUX_IMMUTABLE could
turn off immutability, modify it and then turn it back on, but during
that window, others could modify it too which may be more undesirable
than changing the behavior.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-11 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 18:47 [PATCH] xfs: change the immutable in xfs_open_by_handle Mark Tinguely
2013-09-10 21:20 ` Dave Chinner
2013-09-10 22:29 ` Mark Tinguely
2013-09-11 13:55 ` Christoph Hellwig
2013-09-11 14:22 ` Mark Tinguely [this message]
2013-09-11 15:50 ` Matthias Schniedermeyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52307CB6.3060506@sgi.com \
--to=tinguely@sgi.com \
--cc=gbanks@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox